linux-kernel - Re: [PATCH net-next] mlx4: Remove unused functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f25f3831-8e03-4225-8132-b486d989604e@gmail.com>
Date: Mon, 3 Feb 2025 23:44:00 +0200
From: Tariq Toukan <ttoukan.linux@...il.com>
To: linux@...blig.org, tariqt@...dia.com, andrew+netdev@...n.ch,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, yishaih@...dia.com
Cc: netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
 linux-kernel@...r.kernel.org, Simon Horman <horms@...nel.org>
Subject: Re: [PATCH net-next] mlx4: Remove unused functions



On 03/02/2025 20:52, linux@...blig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
> 
> The last use of mlx4_find_cached_mac() was removed in 2014 by
> commit 2f5bb473681b ("mlx4: Add ref counting to port MAC table for RoCE")
> 
> mlx4_zone_free_entries() was added in 2014 by
> commit 7a89399ffad7 ("net/mlx4: Add mlx4_bitmap zone allocator")
> but hasn't been used. (The _unique version is used)
> 
> Remove them.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> Reviewed-by: Simon Horman <horms@...nel.org>
> ---
>   drivers/net/ethernet/mellanox/mlx4/alloc.c | 22 ----------------------
>   drivers/net/ethernet/mellanox/mlx4/mlx4.h  |  6 ------
>   drivers/net/ethernet/mellanox/mlx4/port.c  | 20 --------------------
>   include/linux/mlx4/device.h                |  1 -
>   4 files changed, 49 deletions(-)
> 

Thanks for your patch.

Reviewed-by: Tariq Toukan <tariqt@...dia.com>

Tariq