linux-kernel - Re: [PATCH] cpufreq: airoha: add CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <3ccab07b-6cb9-46be-8a8e-e7745f5a951f@app.fastmail.com>
Date: Mon, 03 Feb 2025 09:04:39 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Viresh Kumar" <viresh.kumar@...aro.org>,
 "Arnd Bergmann" <arnd@...nel.org>
Cc: "Rafael J . Wysocki" <rafael@...nel.org>,
 "Christian Marangi" <ansuelsmth@...il.com>,
 "Pierre Gondois" <pierre.gondois@....com>, linux-pm@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq: airoha: add CONFIG_OF dependency

On Wed, Jan 22, 2025, at 08:00, Viresh Kumar wrote:
>> 
>> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
>> index 704e84d00639..9e46960f6a86 100644
>> --- a/drivers/cpufreq/Kconfig.arm
>> +++ b/drivers/cpufreq/Kconfig.arm
>> @@ -18,6 +18,7 @@ config ARM_ALLWINNER_SUN50I_CPUFREQ_NVMEM
>>  config ARM_AIROHA_SOC_CPUFREQ
>>  	tristate "Airoha EN7581 SoC CPUFreq support"
>>  	depends on ARCH_AIROHA || COMPILE_TEST
>> +	depends on OF
>>  	select PM_OPP
>>  	default ARCH_AIROHA
>>  	help
>
> Applied. Thanks.
>

It appears that something went wrong when you applied the fix,
the version that is in your tree now makes no sense:

--- a/drivers/cpufreq/Kconfig.arm
+++ b/drivers/cpufreq/Kconfig.arm
@@ -17,7 +17,7 @@ config ARM_ALLWINNER_SUN50I_CPUFREQ_NVMEM

 config ARM_AIROHA_SOC_CPUFREQ
        tristate "Airoha EN7581 SoC CPUFreq support"
-       depends on ARCH_AIROHA || COMPILE_TEST
+       depends on (ARCH_AIROHA && OF) || COMPILE_TEST
        select PM_OPP
        default ARCH_AIROHA
        help

ARCH_AIROHA requires CONFIG_OF, so this change does nothing,
and the dependency is still missing for the COMPILE_TEST case.

      Arnd