linux-kernel - [PATCH v3 0/3] Makefile fixes for samples/{bpf,hid}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250203085506.220297-1-jinghao7@illinois.edu>
Date: Mon,  3 Feb 2025 02:55:03 -0600
From: Jinghao Jia <jinghao7@...inois.edu>
To: Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <martin.lau@...ux.dev>,
        Eduard Zingerman <eddyz87@...il.com>, Song Liu <song@...nel.org>,
        Yonghong Song <yonghong.song@...ux.dev>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>,
        Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
        Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <bentiss@...nel.org>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Nicolas Schier <n.schier@....de>, Ruowen Qin <ruqin@...hat.com>,
        Jinghao Jia <jinghao7@...inois.edu>
Cc: bpf@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-input@...r.kernel.org
Subject: [PATCH v3 0/3] Makefile fixes for samples/{bpf,hid}

Hi everyone,

Following commit 13b25489b6f8 ("kbuild: change working directory to
external module directory with M="), the Makefiles for both bpf and hid
samples are broken due to the use of the relative vmlinux path (i.e.,
./vmlinux) when generating vmlinux.h. Additionally, samples/hid experience
the same problem that was fixed for samples/bpf in commit 5a6ea7022ff4
("samples/bpf: Remove unnecessary -I flags from libbpf EXTRA_CFLAGS").

This patchset makes the following changes to fix these two problems:
 - The first patch applies the same fix from commit 5a6ea7022ff4
   ("samples/bpf: Remove unnecessary -I flags from libbpf EXTRA_CFLAGS") to
   samples/hid.
 - The second and third patch replace the relative vmlinux paths in
   samples/{bpf,hid}/Makefile with $(objtree)/vmlinux to correctly refer to
   the vmlinux in kernel output directory, following the recent working
   directory change in kbuild.

Changelog:
v2 -> v3:
 - v2: https://lore.kernel.org/all/20250123081950.173588-1-jinghao7@illinois.edu/
 - Address feedback from Andrii
  - Split the vmlinux path fixes for bpf and hid
v1 -> v2:
 - v1: https://lore.kernel.org/all/20250120023027.160448-1-jinghao7@illinois.edu/
 - Address feedback from Daniel
  - Apply vmlinux path fix to samples/hid
  - Add a second patch that fixes the include path issue in samples/hid,
    i.e., the same issue fixed fpr samples/bpf in commit 5a6ea7022ff4
    ("samples/bpf: Remove unnecessary -I flags from libbpf EXTRA_CFLAGS")
 - Address feedback from Masahiro and Nicolas
   - Use $(objtree) instead of $(srctree) in the path when referring to
     vmlinux, as it is an artifact of kbuild

Jinghao Jia (3):
  samples/hid: remove unnecessary -I flags from libbpf EXTRA_CFLAGS
  samples/bpf: fix broken vmlinux path for VMLINUX_BTF
  samples/hid: fix broken vmlinux path for VMLINUX_BTF

 samples/bpf/Makefile |  2 +-
 samples/hid/Makefile | 13 +++++++------
 2 files changed, 8 insertions(+), 7 deletions(-)

-- 
2.48.1