linux-kernel - Re: [PATCH v3 1/8] scsi: ufs: core: Pass target_freq to clk_scale

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ceeee4f93b22ab53c4243eec85449a95b0305c70.camel@gmail.com>
Date: Mon, 03 Feb 2025 10:37:56 +0100
From: Bean Huo <huobean@...il.com>
To: Ziqi Chen <quic_ziqichen@...cinc.com>, quic_cang@...cinc.com, 
 bvanassche@....org, mani@...nel.org, beanhuo@...ron.com,
 avri.altman@....com,  junwoo80.lee@...sung.com, martin.petersen@...cle.com,
 quic_nguyenb@...cinc.com,  quic_nitirawa@...cinc.com,
 quic_rampraka@...cinc.com
Cc: linux-arm-msm@...r.kernel.org, linux-scsi@...r.kernel.org, Alim Akhtar
 <alim.akhtar@...sung.com>, "James E.J. Bottomley"
 <James.Bottomley@...senPartnership.com>, Peter Wang
 <peter.wang@...iatek.com>,  Stanley Jhu <chu.stanley@...il.com>, Manivannan
 Sadhasivam <manivannan.sadhasivam@...aro.org>,  Matthias Brugger
 <matthias.bgg@...il.com>, AngeloGioacchino Del Regno
 <angelogioacchino.delregno@...labora.com>,  Andrew Halaney
 <ahalaney@...hat.com>, Eric Biggers <ebiggers@...gle.com>, Minwoo Im
 <minwoo.im@...sung.com>,  open list <linux-kernel@...r.kernel.org>,
 "moderated list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER..."
 <linux-mediatek@...ts.infradead.org>, "moderated list:ARM/Mediatek SoC
 support:Keyword:mediatek" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v3 1/8] scsi: ufs: core: Pass target_freq to
 clk_scale_notify() vop

On Mon, 2025-02-03 at 16:11 +0800, Ziqi Chen wrote:
> From: Can Guo <quic_cang@...cinc.com>
> 
> Instead of only two frequencies, if OPP V2 is used, the UFS devfreq
> clock
> scaling may scale the clock among multiple frequencies, so just
> passing
> up/down to vop clk_scale_notify() is not enough to cover the
> intermediate
> clock freqs between the min and max freqs. Hence pass the target_freq
> ,
> which will be used in successive commits, to clk_scale_notify() to
> allow
> the vop to perform corresponding configurations with regard to the
> clock
> freqs.
> 
> Signed-off-by: Can Guo <quic_cang@...cinc.com>
> Co-developed-by: Ziqi Chen <quic_ziqichen@...cinc.com>
> Signed-off-by: Ziqi Chen <quic_ziqichen@...cinc.com>

I have reviewed patches [1/8], [2/8], [3/8], [4/8] in the v2, since you
just changed coding types, and typos , but no logic change in v3. Add
my review tag agaion:

Reviewed-by: Bean Huo <beanhuo@...ron.com>