linux-kernel - Re: [PATCH] HID: lenovo: select CONFIG_ACPI_PLATFORM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <o2790845-67ns-p6o9-85r0-82q1qnr234np@xreary.bet>
Date: Mon, 3 Feb 2025 10:54:56 +0100 (CET)
From: Jiri Kosina <jikos@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>
cc: Benjamin Tissoires <bentiss@...nel.org>, 
    Vishnu Sankar <vishnuocv@...il.com>, Arnd Bergmann <arnd@...db.de>, 
    linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: lenovo: select CONFIG_ACPI_PLATFORM_PROFILE

On Wed, 22 Jan 2025, Arnd Bergmann wrote:

> From: Arnd Bergmann <arnd@...db.de>
> 
> A previous patch tried to fix this link failure:
> 
> x86_64-linux-ld: drivers/hid/hid-lenovo.o: in function `lenovo_raw_event':
> hid-lenovo.c:(.text+0x22c): undefined reference to `platform_profile_cycle'
> 
> but got it wrong in three ways:
> 
>  - the link failure still exists with CONFIG_ACPI_PLATFORM_PROFILE=m
>    when hid-lenovo is built-in
> 
>  - There is no way to manually enable CONFIG_ACPI_PLATFORM_PROFILE, as
>    it is intended to be selected by its users.
> 
> Remove the broken #if check again and instead select the symbol like
> the other users do. This requires adding a dependency on CONFIG_ACPI.
> 
> Fixes: 52e7d1f7c2fd ("HID: lenovo: Fix undefined platform_profile_cycle in ThinkPad X12 keyboard patch")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thanks a lot for the fix Arnd, applied to hid.git#for-6.14/upstream-fixes.

-- 
Jiri Kosina
SUSE Labs