[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <48c715c2-64ac-4e24-973c-515c8814ea07@intel.com>
Date: Mon, 3 Feb 2025 16:12:54 +0530
From: Mahesh Rao <mahesh.rao@...el.com>
To: Rob Herring <robh@...nel.org>
CC: Moritz Fischer <mdf@...nel.org>, Xu Yilun <yilun.xu@...el.com>, Tom Rix
<trix@...hat.com>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Dinh Nguyen <dinguyen@...nel.org>, Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org>, Wu Hao <hao.wu@...el.com>, Ho Yin
<adrian.ho.yin.ng@...era.com>, Niravkumar L Rabara <nirav.rabara@...era.com>,
<linux-fpga@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, Mahesh Rao <mahesh.rao@...era.com>
Subject: Re: [PATCH v2 2/3] dt-bindings: firmware: stratix10: Convert to
json-schema
Hi Rob,
On 31-01-2025 08:56 pm, Rob Herring wrote:
> On Fri, Jan 31, 2025 at 06:17:25PM +0800, Mahesh Rao wrote:
>> Convert intel,stratix10-svc service layer devicetree
>> binding file from freeform format to json-schema.
>>
>> Also added DT binding for optional stratix10-soc
>> FPGA manager child node.
>>
>> Signed-off-by: Mahesh Rao<mahesh.rao@...el.com>
>> ---
>> +maintainers:
>> + - Dinh Nguyen<dinguyen@...nel.org>
>> + - Mahesh Rao<mahesh.rao@...era.com>
>> +
>> +description:
> You need '>' on the end to preserve paragraphs.
Will make the change.
> + - intel,stratix10-svc
> + - intel,agilex-svc
> +
> + method:
> + description: |
> + Supervisory call method to be used to communicate with the
> + secure service layer.
> + Permitted values are:
> + - "smc" : SMC #0, following the SMCCC
> + - "hvc" : HVC #0, following the SMCCC
> Indent by 2 more than 'description'.
OK, will add the change.
>> + memory-region:
>> + maxItems: 1
>> + description:
>> + phandle to a reserved memory region for the service layer driver to
>> + communicate with the secure device manager. For more details see
>> + Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt.
> Please read what that file says.
reserved-memory is moved to dtschema, shall I change this to the following?
memory-region:
maxItems: 1
description:
Phandle to a reserved memory region for the service layer driver to
communicate with the secure device manager.
(See reserved-memory in dtschema project.)
Is this what is required?
Best regards
Mahesh Rao
Powered by blists - more mailing lists