linux-kernel - Re: [PATCH v2] tee: optee: Fix supplicant wait loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <65aedfdf-0a13-445d-956c-6945f1b49681@app.fastmail.com>
Date: Mon, 03 Feb 2025 11:53:11 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Jens Wiklander" <jens.wiklander@...aro.org>,
 "Sumit Garg" <sumit.garg@...aro.org>
Cc: op-tee@...ts.trustedfirmware.org,
 "Jerome Forissier" <jerome.forissier@...aro.org>, dannenberg@...com,
 javier@...igon.com, linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v2] tee: optee: Fix supplicant wait loop

On Mon, Feb 3, 2025, at 10:31, Jens Wiklander wrote:
> On Mon, Feb 3, 2025 at 9:00 AM Sumit Garg <sumit.garg@...aro.org> wrote:

> Why not mutex_lock()? If we fail to acquire the mutex here, we will
> quite likely free the req list item below at the end of this function
> while it remains in the list.

Right, I had mentioned mutex_lock_killable in an earlier reply,
as I didn't know exactly where it hang. If we know that the
wait_event_interruptible() was causing the hang, then the
normal mutex_lock should be fine.

     Arnd