linux-kernel - Re: [PATCH] cpufreq: airoha: add CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <d1ed3940-976b-47d0-b5e0-9bf08f687246@app.fastmail.com>
Date: Mon, 03 Feb 2025 11:54:21 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Viresh Kumar" <viresh.kumar@...aro.org>
Cc: "Arnd Bergmann" <arnd@...nel.org>,
 "Rafael J . Wysocki" <rafael@...nel.org>,
 "Christian Marangi" <ansuelsmth@...il.com>,
 "Pierre Gondois" <pierre.gondois@....com>, linux-pm@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq: airoha: add CONFIG_OF dependency

On Mon, Feb 3, 2025, at 10:21, Viresh Kumar wrote:
>
> Going to send this patch now, lemme know if it looks okay:
>
>
>     It would be possible to mark the variable as __maybe_unused to shut up
>     that warning, but a Kconfig dependency seems more appropriate as this still
>     allows build testing in allmodconfig and randconfig builds on all
>     architectures.
>
>     An earlier commit, b865a8404642 ("cpufreq: airoha: Depends on OF"),
>     tried to fix it incorrectly. ARCH_AIROHA already requires CONFIG_OF, so
>     this change does nothing, and the dependency is still missing for the
>     COMPILE_TEST case.
>
>     Fix it properly.
>
>     Fixes: 84cf9e541ccc ("cpufreq: airoha: Add EN7581 CPUFreq SMCCC driver")
>     Fixes: b865a8404642 ("cpufreq: airoha: Depends on OF")
>     Signed-off-by: Arnd Bergmann <arnd@...db.de>
>     [ Viresh: updated commit log and fixed rebase conflict ]
>     Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>

Looks good to me, thanks!

    Arnd