linux-kernel - Re: [PATCH v3 00/14] Change ghes to use HEST-based offsets and add support for error inject

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250203110934.000038d8@huawei.com>
Date: Mon, 3 Feb 2025 11:09:34 +0000
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
CC: Igor Mammedov <imammedo@...hat.com>, "Michael S . Tsirkin"
	<mst@...hat.com>, Shiju Jose <shiju.jose@...wei.com>, <qemu-arm@...gnu.org>,
	<qemu-devel@...gnu.org>, Philippe Mathieu-Daudé
	<philmd@...aro.org>, Ani Sinha <anisinha@...hat.com>, Cleber Rosa
	<crosa@...hat.com>, Dongjiu Geng <gengdongjiu1@...il.com>, Eduardo Habkost
	<eduardo@...kost.net>, Eric Blake <eblake@...hat.com>, John Snow
	<jsnow@...hat.com>, Marcel Apfelbaum <marcel.apfelbaum@...il.com>, "Markus
 Armbruster" <armbru@...hat.com>, Michael Roth <michael.roth@....com>, "Paolo
 Bonzini" <pbonzini@...hat.com>, Peter Maydell <peter.maydell@...aro.org>,
	Shannon Zhao <shannon.zhaosl@...il.com>, Yanan Wang <wangyanan55@...wei.com>,
	Zhao Liu <zhao1.liu@...el.com>, <kvm@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 00/14] Change ghes to use HEST-based offsets and add
 support for error inject

On Fri, 31 Jan 2025 18:42:41 +0100
Mauro Carvalho Chehab <mchehab+huawei@...nel.org> wrote:

> Now that the ghes preparation patches were merged, let's add support
> for error injection.
> 
> On this series, the first 6 patches chang to the math used to calculate offsets at HEST
> table and hardware_error firmware file, together with its migration code. Migration tested
> with both latest QEMU released kernel and upstream, on both directions.
> 
> The next patches add a new QAPI to allow injecting GHESv2 errors, and a script using such QAPI
>    to inject ARM Processor Error records.
> 
> If I'm counting well, this is the 19th submission of my error inject patches.

Looks good to me. All remaining trivial things are in the category
of things to consider only if you are doing another spin.  The code
ends up how I'd like it at the end of the series anyway, just
a question of the precise path to that state!

Jonathan