linux-kernel - Re: [PATCH 0/3] Cleanup for Intel PMU initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250203131600.GD14028@noisy.programming.kicks-ass.net>
Date: Mon, 3 Feb 2025 14:16:00 +0100
From: Peter Zijlstra <peterz@...radead.org>
To: kan.liang@...ux.intel.com
Cc: mingo@...hat.com, acme@...nel.org, namhyung@...nel.org,
	irogers@...gle.com, adrian.hunter@...el.com,
	alexander.shishkin@...ux.intel.com, ak@...ux.intel.com,
	linux-kernel@...r.kernel.org, dapeng1.mi@...ux.intel.com
Subject: Re: [PATCH 0/3] Cleanup for Intel PMU initialization

On Wed, Jan 29, 2025 at 07:48:17AM -0800, kan.liang@...ux.intel.com wrote:
> From: Kan Liang <kan.liang@...ux.intel.com>
> 
> The patches are to clean up different features. They all touch the
> initialization code. There are some dependencies. So I put them in
> a patch set to facilitate the review and merge.
> 
> Patch 1 is to clear up the PEBS-via-PT on hybrid.
> The original V1 patch can be found at
> https://lore.kernel.org/lkml/20250124183432.3565061-1-kan.liang@linux.intel.com/
> This is the V2, which only update the comments.
> 
> Patch 2 is to clean up the 023H enumeration.
> To close the discussion at
> https://lore.kernel.org/lkml/20250127212901.GB9557@noisy.programming.kicks-ass.net/
> 
> Patch 3 is to clean up the counter information update and check codes.
> To close the discussion at
> https://lore.kernel.org/lkml/20250127164406.GN16742@noisy.programming.kicks-ass.net/

So I can take 1 and 2, but 3 is part of that arch pebs things, and that
series is not in a shape I want to apply.

Also, I'm not at all sure 3 improves things, it might just make it
worse.