linux-kernel - Aw: Re: [PATCH] mfd: syscon: Restore device_node_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <trinity-23c8b516-bcfd-4dc9-8810-5e17510b159b-1738588594123@trinity-msg-rest-gmx-gmx-live-548599f845-t5dbc>
Date: Mon, 3 Feb 2025 13:16:34 +0000
From: Frank Wunderlich <frank-w@...lic-files.de>
To: daniel@...rotopia.org, robh@...nel.org
Cc: lee@...nel.org, arnd@...db.de, krzysztof.kozlowski@...aro.org,
 pankaj.dubey@...sung.com, willmcvicker@...gle.com,
 john.madieu.xa@...renesas.com, nm@...com, vaishnav.a@...com,
 rafal@...ecki.pl, john@...ozen.org, linux-kernel@...r.kernel.org
Subject: Aw: Re: [PATCH] mfd: syscon: Restore device_node_to_regmap() for
 non-syscon nodes


regards Frank


> Gesendet: Sonntag, 2. Februar 2025 um 23:57
> Von: "Daniel Golle" <daniel@...rotopia.org>
> Betreff: Re: [PATCH] mfd: syscon: Restore device_node_to_regmap() for non-syscon nodes
>
> On Fri, Jan 24, 2025 at 01:16:44PM -0600, Rob Herring (Arm) wrote:
> > Commit ba5095ebbc7a ("mfd: syscon: Allow syscon nodes without a
> > "syscon" compatible") broke drivers which call device_node_to_regmap()
> > on nodes without a "syscon" compatible. Restore the prior behavior for
> > device_node_to_regmap().
> >
> > This also makes using device_node_to_regmap() incompatible with
> > of_syscon_register_regmap() again, so add kerneldoc for
> > device_node_to_regmap() and syscon_node_to_regmap() to make it clear
> > how and when each one should be used.
> >
> > Fixes: ba5095ebbc7a ("mfd: syscon: Allow syscon nodes without a "syscon" compatible")
> > Cc: Will McVicker <willmcvicker@...gle.com>
> > Cc: John Madieu <john.madieu.xa@...renesas.com>
> > Cc: Nishanth Menon <nm@...com>
> > Reported-by: Vaishnav Achath <vaishnav.a@...com>
> > Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> > ---
>
> Reviewed-by: Daniel Golle <daniel@...rotopia.org>
> Texted-by: Daniel Golle <daniel@...rotopia.org>

fixing Daniels Tested-by-tag :)
Tested-by: Daniel Golle <daniel@...rotopia.org>
and confirming the patch fixes the clock-syscon-issue (on mt7988)
Tested-by: Frank Wunderlich <frank-w@...lic-files.de>

> This fix is required to un-break various Mediatek clock drivers as
> device_node_to_regmap() is used all over the place there (in
> reset.c, clk-gate.c, clk-cpumux.c, clk-mux.c) and commit
> 3ba5a6159434 ("arm64: dts: mediatek: mt7622: fix clock controllers")
> has droped all those unneeded "syscon"s.