linux-kernel - Re: [PATCH v2] usb: usb251xb: silence EPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <i2qbsl5vhi7ltwxabmnbeiixcb4kmliezuokmv7sknkfgzwgns@g4jhh4ldugcz>
Date: Mon, 3 Feb 2025 14:21:07 +0100
From: Richard Leitner <richard.leitner@...ux.dev>
To: Dominique Martinet <dominique.martinet@...ark-techno.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] usb: usb251xb: silence EPROBE_DEFER error on boot

On Mon, Feb 03, 2025 at 03:33:49PM +0900, Dominique Martinet wrote:
> Use dev_err_probe to silence EPROBE_DEFER error on boot:
> [    0.757677] usb251xb 1-002c: failed to get ofdata: -517
> 
> Signed-off-by: Dominique Martinet <dominique.martinet@...ark-techno.com>
> ---
> Changes in v2:
> - removed redundant error code in message and brace
> - Link to v1: https://lore.kernel.org/r/20250203-defer_usb1-v1-1-f6bba254215d@atmark-techno.com
> ---
>  drivers/usb/misc/usb251xb.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c
> index e24cdb667307802b9eee856e20744ebf694395e8..4fb453ca545013f8b89c43d3bb5cc6d1c53b39c9 100644
> --- a/drivers/usb/misc/usb251xb.c
> +++ b/drivers/usb/misc/usb251xb.c
> @@ -636,10 +636,8 @@ static int usb251xb_probe(struct usb251xb *hub)
>  
>  	if (np && usb_data) {
>  		err = usb251xb_get_ofdata(hub, usb_data);
> -		if (err) {
> -			dev_err(dev, "failed to get ofdata: %d\n", err);
> -			return err;
> -		}
> +		if (err)
> +			return dev_err_probe(dev, err, "failed to get ofdata\n");
>  	}
>  
>  	/*
> 
> ---
> base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b
> change-id: 20250203-defer_usb1-254070d18cc9

Acked-by: Richard Leitner <richard.leitner@...ux.dev>