linux-kernel - Re: [PATCH 02/33] dt-bindings: clock: add clock definitions for exynos7870 CMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9c8a9dee-92ba-47e4-b16b-ab47727d8057@kernel.org>
Date: Mon, 3 Feb 2025 15:01:22 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Kaustabh Chakraborty <kauschluss@...root.org>
Cc: Rob Herring <robh@...nel.org>, Conor Dooley <conor@...nel.org>,
 Alim Akhtar <alim.akhtar@...sung.com>,
 Sylwester Nawrocki <s.nawrocki@...sung.com>,
 Chanwoo Choi <cw00.choi@...sung.com>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Tomasz Figa <tomasz.figa@...il.com>,
 Linus Walleij <linus.walleij@...aro.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Jiri Slaby <jirislaby@...nel.org>, Lee Jones <lee@...nel.org>,
 Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Vinod Koul <vkoul@...nel.org>, Kishon Vijay Abraham I <kishon@...nel.org>,
 Marek Szyprowski <m.szyprowski@...sung.com>, David Airlie
 <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 Andi Shyti <andi.shyti@...nel.org>, Ulf Hansson <ulf.hansson@...aro.org>,
 Jaehoon Chung <jh80.chung@...sung.com>,
 Vivek Gautam <gautam.vivek@...sung.com>,
 Thinh Nguyen <Thinh.Nguyen@...opsys.com>, Kees Cook <kees@...nel.org>,
 Tony Luck <tony.luck@...el.com>, "Guilherme G . Piccoli"
 <gpiccoli@...lia.com>, Sergey Lisov <sleirsgoevy@...il.com>,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-clk@...r.kernel.org, linux-gpio@...r.kernel.org,
 linux-serial@...r.kernel.org, linux-phy@...ts.infradead.org,
 linux-usb@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 linux-i2c@...r.kernel.org, linux-mmc@...r.kernel.org,
 linux-hardening@...r.kernel.org
Subject: Re: [PATCH 02/33] dt-bindings: clock: add clock definitions for
 exynos7870 CMU

On 03/02/2025 13:40, Kaustabh Chakraborty wrote:
> On 2025-02-03 07:54, Krzysztof Kozlowski wrote:
>> On Mon, Feb 03, 2025 at 12:37:58AM +0530, Kaustabh Chakraborty wrote:
>>> From: Sergey Lisov <sleirsgoevy@...il.com>
>>>
>>> Add unique identifiers for exynos7870 clocks for every bank. It adds all
>>> clocks of CMU_MIF, CMU_DISPAUD, CMU_G3D, CMU_ISP, CMU_MFCMSCL, and
>>> CMU_PERI.
>>>
>>> Signed-off-by: Sergey Lisov <sleirsgoevy@...il.com>
>>> Signed-off-by: Kaustabh Chakraborty <kauschluss@...root.org>
>>> ---
>>>  include/dt-bindings/clock/exynos7870.h | 324 +++++++++++++++++++++++++
>>>  1 file changed, 324 insertions(+)
>>
>> Look at git log - that's never a separate commit.
> 
> Hmm, I see past examples which are mixed.
> 
> 2ae5c2c3f8d586b709cf67efe94488be397d7544
> Exynos850 CMU (c. 2021). CMU definitions are in a separate commit.
> 
> 591020a516720e9eba1c4b1748cb73b6748e445f
> Exynos7885 CMU (c. 2021). CMU definitions are in a separate commit.
> 
Huh, indeed, my mistake.

Let's avoid that pattern, so binding headers are always part of bindings
commit.

Best regards,
Krzysztof