linux-kernel - Re: [PATCH] ASoC: q6apm-dai: schedule all the periods before we start streaming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <357e28eb-f245-4647-8e10-79805b53731e@sirena.org.uk>
Date: Mon, 3 Feb 2025 14:17:51 +0000
From: Mark Brown <broonie@...nel.org>
To: srinivas.kandagatla@...aro.org
Cc: lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
	krzysztof.kozlowski@...aro.org, pierre-louis.bossart@...ux.dev,
	linux-sound@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	linux-kernel@...r.kernel.org, dmitry.baryshkov@...aro.org
Subject: Re: [PATCH] ASoC: q6apm-dai: schedule all the periods before we
 start streaming

On Mon, Feb 03, 2025 at 12:49:45PM +0000, srinivas.kandagatla@...aro.org wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> 
> With the existing code, we are only setting up one period at a time, in a
> ping-pong buffer style. This tiggers lot of underruns in the dsp
> leading to jitter noise during audio playback.
> 
> Fix this by scheduling all the periods, this will ensure that the dsp
> has enough buffer feed and ultimatley fixing the underruns and audio
> distortion.

Should we be writing all periods or just the minimum number of periods
that's configured?  Userspace might not have filled the whole buffer
yet.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)