linux-kernel - Re: [PATCH] powerpc: mpic: Use str_enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <D7JUVZEI35EG.3CK5XCVGHEFN0@marliere.net>
Date: Tue, 04 Feb 2025 15:00:37 -0300
From: Ricardo B. Marlière <ricardo@...liere.net>
To: "Thorsten Blum" <thorsten.blum@...ux.dev>, "Madhavan Srinivasan"
 <maddy@...ux.ibm.com>, "Michael Ellerman" <mpe@...erman.id.au>, "Nicholas
 Piggin" <npiggin@...il.com>, "Christophe Leroy"
 <christophe.leroy@...roup.eu>, "Naveen N Rao" <naveen@...nel.org>, "Greg
 Kroah-Hartman" <gregkh@...uxfoundation.org>
Cc: <linuxppc-dev@...ts.ozlabs.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] powerpc: mpic: Use str_enabled_disabled() helper
 function

On Tue Feb 4, 2025 at 12:44 PM -03, Thorsten Blum wrote:
> Remove hard-coded strings by using the str_enabled_disabled() helper
> function.
>
> Use pr_debug() instead of printk(KERN_DEBUG) to silence a checkpatch
> warning.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>

Reviewed-by: Ricardo B. Marlière <ricardo@...liere.net>

> ---
>  arch/powerpc/sysdev/mpic.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/arch/powerpc/sysdev/mpic.c b/arch/powerpc/sysdev/mpic.c
> index d94cf36b0f65..25fc4ac91814 100644
> --- a/arch/powerpc/sysdev/mpic.c
> +++ b/arch/powerpc/sysdev/mpic.c
> @@ -27,6 +27,7 @@
>  #include <linux/spinlock.h>
>  #include <linux/pci.h>
>  #include <linux/slab.h>
> +#include <linux/string_choices.h>
>  #include <linux/syscore_ops.h>
>  #include <linux/ratelimit.h>
>  #include <linux/pgtable.h>
> @@ -474,9 +475,9 @@ static void __init mpic_scan_ht_msi(struct mpic *mpic, u8 __iomem *devbase,
>  		addr = addr | ((u64)readl(base + HT_MSI_ADDR_HI) << 32);
>  	}
>  
> -	printk(KERN_DEBUG "mpic:   - HT:%02x.%x %s MSI mapping found @ 0x%llx\n",
> -		PCI_SLOT(devfn), PCI_FUNC(devfn),
> -		flags & HT_MSI_FLAGS_ENABLE ? "enabled" : "disabled", addr);
> +	pr_debug("mpic:   - HT:%02x.%x %s MSI mapping found @ 0x%llx\n",
> +		 PCI_SLOT(devfn), PCI_FUNC(devfn),
> +		 str_enabled_disabled(flags & HT_MSI_FLAGS_ENABLE), addr);
>  
>  	if (!(flags & HT_MSI_FLAGS_ENABLE))
>  		writeb(flags | HT_MSI_FLAGS_ENABLE, base + HT_MSI_FLAGS);