linux-kernel - Re: [PATCH 1/2] AutoFDO: Remove the architecture specific config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202502041204.5244DFA862@keescook>
Date: Tue, 4 Feb 2025 12:04:35 -0800
From: Kees Cook <kees@...nel.org>
To: Rong Xu <xur@...gle.com>
Cc: Masahiro Yamada <masahiroy@...nel.org>, Yabin Cui <yabinc@...gle.com>,
	Will Deacon <will@...nel.org>, Han Shen <shenhan@...gle.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Sami Tolvanen <samitolvanen@...gle.com>,
	Alice Ryhl <aliceryhl@...gle.com>,
	"Mike Rapoport (Microsoft)" <rppt@...nel.org>,
	Samuel Holland <samuel.holland@...ive.com>,
	"Paul E. McKenney" <paulmck@...nel.org>,
	Arnd Bergmann <arnd@...db.de>, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] AutoFDO: Remove the architecture specific config

On Wed, Dec 11, 2024 at 02:29:42PM -0800, Rong Xu wrote:
> The CONFIG_AUTOFDO_CLANG option currently depends on
> ARCH_SUPPORTS_AUTOFDO_CLANG, but this dependency seems unnecessary.
> 
> Remove ARCH_SUPPORTS_AUTOFDO_CLANG and allow users to control AutoFDO
> builds solely through CONFIG_AUTOFDO_CLANG. This simplifies the kconfig
> and avoids potential confusion.
> 
> Signed-off-by: Rong Xu <xur@...gle.com>

Looks right to me!

Reviewed-by: Kees Cook <kees@...nel.org>

-- 
Kees Cook