linux-kernel - Re: [PATCH V10 4/4] perf/x86/intel: Support PEBS counters snapshotting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f3b71bfb-4e04-48a2-b606-bac81cd3f50e@linux.intel.com>
Date: Tue, 4 Feb 2025 16:09:09 -0500
From: "Liang, Kan" <kan.liang@...ux.intel.com>
To: Peter Zijlstra <peterz@...radead.org>
Cc: mingo@...hat.com, acme@...nel.org, namhyung@...nel.org,
 irogers@...gle.com, adrian.hunter@...el.com, linux-kernel@...r.kernel.org,
 linux-perf-users@...r.kernel.org, ak@...ux.intel.com, eranian@...gle.com,
 dapeng1.mi@...ux.intel.com
Subject: Re: [PATCH V10 4/4] perf/x86/intel: Support PEBS counters
 snapshotting

Hi Peter,

On 2025-01-27 10:51 a.m., Peter Zijlstra wrote:
> On Tue, Jan 21, 2025 at 07:23:03AM -0800, kan.liang@...ux.intel.com wrote:
> 
>> @@ -471,6 +477,15 @@ struct pebs_xmm {
>>  
>>  #define IBS_CPUID_FEATURES		0x8000001b
>>  
>> +struct pebs_cntr_header {
>> +	u32 cntr;
>> +	u32 fixed;
>> +	u32 metrics;
>> +	u32 reserved;
>> +};
>> +
>> +#define INTEL_CNTR_METRICS		0x3
> 
> I've moved this up a little, so that all the adaptive pebs crud is
> together.
> 
> Other than that, I've picked up these patches and will merge the lot
> past -rc1.
> 

We found a bug when testing with some non-precise events in freq mode.
I've submitted a patch to fix it.
https://lore.kernel.org/lkml/20250204210514.4089680-1-kan.liang@linux.intel.com/

Could you please fold it into the patch ("perf/x86/intel: Support PEBS
counters snapshotting")?

Sorry for any inconvenience.

Thanks,
Kan