linux-kernel - Re: [PATCH v6 5/7] watchdog: Add Nuvoton NCT6694 WDT support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOoeyxUqHs2NRh1-2DJ0vj3dquQjETdNFNf0_4buATb2dG458A@mail.gmail.com>
Date: Tue, 4 Feb 2025 10:44:11 +0800
From: Ming Yu <a0282524688@...il.com>
To: Vincent Mailhol <mailhol.vincent@...adoo.fr>
Cc: tmyu0@...oton.com, lee@...nel.org, linus.walleij@...aro.org, brgl@...ev.pl, 
	andi.shyti@...nel.org, mkl@...gutronix.de, andrew+netdev@...n.ch, 
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, 
	wim@...ux-watchdog.org, linux@...ck-us.net, jdelvare@...e.com, 
	alexandre.belloni@...tlin.com, linux-kernel@...r.kernel.org, 
	linux-gpio@...r.kernel.org, linux-i2c@...r.kernel.org, 
	linux-can@...r.kernel.org, netdev@...r.kernel.org, 
	linux-watchdog@...r.kernel.org, linux-hwmon@...r.kernel.org, 
	linux-rtc@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH v6 5/7] watchdog: Add Nuvoton NCT6694 WDT support

Dear Vincent,

Thank you for reviewing,
I will make the change in the next patch.


Best regards,
Ming


Vincent Mailhol <mailhol.vincent@...adoo.fr> 於 2025年1月26日 週日 下午6:13寫道：
>
> On 23/01/2025 at 18:11, Ming Yu wrote:
> > This driver supports Watchdog timer functionality for NCT6694 MFD
> > device based on USB interface.
> >
> > Signed-off-by: Ming Yu <a0282524688@...il.com>
> > ---
>
> (...)
>
> > +static int nct6694_wdt_set_timeout(struct watchdog_device *wdev,
> > +                                unsigned int timeout)
> > +{
> > +     int ret;
> > +
> > +     ret = nct6694_wdt_setting(wdev, timeout, NCT6694_ACTION_GPO,
> > +                               wdev->pretimeout, NCT6694_ACTION_GPO);
> > +     if (ret)
> > +             return ret;
> > +
> > +     wdev->timeout = timeout;
> > +
> > +     return 0;
> > +}
>
> Not critical but I would rather like you to fix this shadow warning:
>
>   drivers/watchdog/nct6694_wdt.c: In function 'nct6694_wdt_set_timeout':
>   drivers/watchdog/nct6694_wdt.c:168:49: warning: declaration of
> 'timeout' shadows a global declaration [-Wshadow]
>     168 |                                    unsigned int timeout)
>         |                                    ~~~~~~~~~~~~~^~~~~~~
>   drivers/watchdog/nct6694_wdt.c:36:21: note: shadowed declaration is here
>      36 | static unsigned int timeout = NCT6694_DEFAULT_TIMEOUT;
>         |                     ^~~~~~~
>
> > +static int nct6694_wdt_set_pretimeout(struct watchdog_device *wdev,
> > +                                   unsigned int pretimeout)
> > +{
> > +     int ret;
> > +
> > +     ret = nct6694_wdt_setting(wdev, wdev->timeout, NCT6694_ACTION_GPO,
> > +                               pretimeout, NCT6694_ACTION_GPO);
> > +     if (ret)
> > +             return ret;
> > +
> > +     wdev->pretimeout = pretimeout;
> > +
> > +     return 0;
> > +}
>
> Idem:
>
>   drivers/watchdog/nct6694_wdt.c: In function 'nct6694_wdt_set_pretimeout':
>   drivers/watchdog/nct6694_wdt.c:183:52: warning: declaration of
> 'pretimeout' shadows a global declaration [-Wshadow]
>     183 |                                       unsigned int pretimeout)
>         |                                       ~~~~~~~~~~~~~^~~~~~~~~~
>   drivers/watchdog/nct6694_wdt.c:40:21: note: shadowed declaration is here
>      40 | static unsigned int pretimeout = NCT6694_DEFAULT_PRETIMEOUT;
>         |                     ^~~~~~~~~~
>
> (...)
>
>
> Yours sincerely,
> Vincent Mailhol
>