linux-kernel - [PATCH RESEND 1/7] firmware: cs_dsp: Fix error checking in wseq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250204231835.2000457-2-ftreven@opensource.cirrus.com>
Date: Tue, 4 Feb 2025 17:18:30 -0600
From: Fred Treven <ftreven@...nsource.cirrus.com>
To: Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>,
        "Krzysztof
 Kozlowski" <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        "Simon
 Trimmer" <simont@...nsource.cirrus.com>,
        Charles Keepax
	<ckeepax@...nsource.cirrus.com>,
        Richard Fitzgerald
	<rf@...nsource.cirrus.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        James Ogletree <jogletre@...nsource.cirrus.com>,
        Ben Bright
	<ben.bright@...rus.com>,
        Liam Girdwood <lgirdwood@...il.com>, Mark Brown
	<broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai
	<tiwai@...e.com>,
        David Rhodes <david.rhodes@...rus.com>,
        Jeff LaBundy
	<jeff@...undy.com>, Heiko Stuebner <heiko@...ech.de>,
        Karel Balej
	<balejk@...fyz.cz>,
        Igor Prusov <ivprusov@...utedevices.com>,
        Jack Yu
	<jack.yu@...ltek.com>,
        Weidong Wang <wangweidong.a@...nic.com>,
        Binbin Zhou
	<zhoubinbin@...ngson.cn>,
        Prasad Kumpatla <quic_pkumpatl@...cinc.com>,
        "Paul
 Handrigan" <paulha@...nsource.cirrus.com>,
        Masahiro Yamada
	<masahiroy@...nel.org>, Nuno Sa <nuno.sa@...log.com>,
        Fred Treven
	<ftreven@...nsource.cirrus.com>
CC: <alsa-devel@...a-project.org>, <patches@...nsource.cirrus.com>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-input@...r.kernel.org>, <linux-sound@...r.kernel.org>
Subject: [PATCH RESEND 1/7] firmware: cs_dsp: Fix error checking in wseq_write()

cs_dsp_coeff_write_ctrl() may return a non-zero value (1)
upon success. Change error checking in the write sequencer
code such that it checks for negative errnos rather than
any non-zero value when using this function.

Signed-off-by: Fred Treven <ftreven@...nsource.cirrus.com>
---
 drivers/firmware/cirrus/cs_dsp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/firmware/cirrus/cs_dsp.c b/drivers/firmware/cirrus/cs_dsp.c
index 5365e9a43000..56315b0b5583 100644
--- a/drivers/firmware/cirrus/cs_dsp.c
+++ b/drivers/firmware/cirrus/cs_dsp.c
@@ -3702,7 +3702,7 @@ int cs_dsp_wseq_write(struct cs_dsp *dsp, struct cs_dsp_wseq *wseq,
 
 		ret = cs_dsp_coeff_write_ctrl(wseq->ctl, op_end->offset / sizeof(u32),
 					      &op_end->data, sizeof(u32));
-		if (ret)
+		if (ret < 0)
 			goto op_new_free;
 
 		list_add_tail(&op_new->list, &op_end->list);
@@ -3710,7 +3710,7 @@ int cs_dsp_wseq_write(struct cs_dsp *dsp, struct cs_dsp_wseq *wseq,
 
 	ret = cs_dsp_coeff_write_ctrl(wseq->ctl, op_new->offset / sizeof(u32),
 				      words, new_op_size);
-	if (ret)
+	if (ret < 0)
 		goto op_new_free;
 
 	return 0;
-- 
2.34.1