linux-kernel - [PATCH RESEND 2/7] firmware: cs_dsp: Check for valid num_regs in cs_dsp_wseq_multi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250204231835.2000457-3-ftreven@opensource.cirrus.com>
Date: Tue, 4 Feb 2025 17:18:31 -0600
From: Fred Treven <ftreven@...nsource.cirrus.com>
To: Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>,
        "Krzysztof
 Kozlowski" <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        "Simon
 Trimmer" <simont@...nsource.cirrus.com>,
        Charles Keepax
	<ckeepax@...nsource.cirrus.com>,
        Richard Fitzgerald
	<rf@...nsource.cirrus.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        James Ogletree <jogletre@...nsource.cirrus.com>,
        Ben Bright
	<ben.bright@...rus.com>,
        Liam Girdwood <lgirdwood@...il.com>, Mark Brown
	<broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai
	<tiwai@...e.com>,
        David Rhodes <david.rhodes@...rus.com>,
        Jeff LaBundy
	<jeff@...undy.com>, Heiko Stuebner <heiko@...ech.de>,
        Karel Balej
	<balejk@...fyz.cz>,
        Igor Prusov <ivprusov@...utedevices.com>,
        Jack Yu
	<jack.yu@...ltek.com>,
        Weidong Wang <wangweidong.a@...nic.com>,
        Binbin Zhou
	<zhoubinbin@...ngson.cn>,
        Prasad Kumpatla <quic_pkumpatl@...cinc.com>,
        "Paul
 Handrigan" <paulha@...nsource.cirrus.com>,
        Masahiro Yamada
	<masahiroy@...nel.org>, Nuno Sa <nuno.sa@...log.com>,
        Fred Treven
	<ftreven@...nsource.cirrus.com>
CC: <alsa-devel@...a-project.org>, <patches@...nsource.cirrus.com>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-input@...r.kernel.org>, <linux-sound@...r.kernel.org>
Subject: [PATCH RESEND 2/7] firmware: cs_dsp: Check for valid num_regs in cs_dsp_wseq_multi_write()

If a value of 0 or below is passed into cs_dsp_wseq_multi_write()
the function will never enter its for loop.

Verify that num_regs passed into the function is valid
and throw a user-visible error if not.

Signed-off-by: Fred Treven <ftreven@...nsource.cirrus.com>
---
 drivers/firmware/cirrus/cs_dsp.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/firmware/cirrus/cs_dsp.c b/drivers/firmware/cirrus/cs_dsp.c
index 56315b0b5583..aacf6960d1ea 100644
--- a/drivers/firmware/cirrus/cs_dsp.c
+++ b/drivers/firmware/cirrus/cs_dsp.c
@@ -3743,6 +3743,11 @@ int cs_dsp_wseq_multi_write(struct cs_dsp *dsp, struct cs_dsp_wseq *wseq,
 {
 	int i, ret;
 
+	if (num_regs <= 0) {
+		cs_dsp_err(dsp, "Invalid number of regs: %d\n", num_regs);
+		return -EINVAL;
+	}
+
 	for (i = 0; i < num_regs; i++) {
 		ret = cs_dsp_wseq_write(dsp, wseq, reg_seq[i].reg,
 					reg_seq[i].def, op_code, update);
-- 
2.34.1