linux-kernel - Re: [PATCH v2 1/4] perf trace: Allocate syscall stats only if summary is on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z6GCde4XqCuEZlgz@google.com>
Date: Mon, 3 Feb 2025 18:59:01 -0800
From: Namhyung Kim <namhyung@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Arnaldo Carvalho de Melo <acme@...nel.org>,
	Kan Liang <kan.liang@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
	linux-perf-users@...r.kernel.org,
	Howard Chu <howardchu95@...il.com>
Subject: Re: [PATCH v2 1/4] perf trace: Allocate syscall stats only if
 summary is on

On Sat, Feb 01, 2025 at 10:57:00PM -0800, Ian Rogers wrote:
> On Wed, Jan 29, 2025 at 7:05 PM Namhyung Kim <namhyung@...nel.org> wrote:
> >
> > The syscall stats are used only when summary is requested.  Let's avoid
> > unnecessary operations.  Pass 'trace' pointer to check summary and give
> > output file together.
> 
> I don't think this last sentence makes sense.

Thanks for your review.  I'd say:  Pass 'trace' pointer instead of doing
'summary' option and 'output' file pointer separately.

Thanks,
Namhyung