linux-kernel - Re: [PATCH] tools/power/x86/intel-speed-select: Prefix header search path with sysroot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f5b4881928e3395eee9b6e6a4fb89f3d605cfd2e.camel@linux.intel.com>
Date: Mon, 03 Feb 2025 19:43:17 -0800
From: srinivas pandruvada <srinivas.pandruvada@...ux.intel.com>
To: Khem Raj <raj.khem@...il.com>, platform-driver-x86@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Cc: Len Brown <len.brown@...el.com>
Subject: Re: [PATCH] tools/power/x86/intel-speed-select: Prefix header
 search path with sysroot

On Tue, 2025-01-28 at 19:39 -0800, Khem Raj wrote:
> This helps when using a cross-compiler for building intel-speed-
> select,
> currently, its hardcoded to pick libnl3 headers from build host which
> may
> not be same as build target when cross compiling.
> 
> cc -print-sysroot will print nothing if compiler is configured
> without
> a sysroot and result in same string as it is now.
> 
> Fixes errors with gcc configured with host include poisoning e.g.
> 
> cc1: error: include location "/usr/include/libnl3" is unsafe for
> cross-compilation [-Werror=poison-system-directories]
> 
> Signed-off-by: Khem Raj <raj.khem@...il.com>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
> Cc: Len Brown <len.brown@...el.com>

Thanks. will take for the next release.

-Srinivas

> ---
>  tools/power/x86/intel-speed-select/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/power/x86/intel-speed-select/Makefile
> b/tools/power/x86/intel-speed-select/Makefile
> index 7221f2f55e8b..8d3a02a20f3d 100644
> --- a/tools/power/x86/intel-speed-select/Makefile
> +++ b/tools/power/x86/intel-speed-select/Makefile
> @@ -13,7 +13,7 @@ endif
>  # Do not use make's built-in rules
>  # (this improves performance and avoids hard-to-debug behaviour);
>  MAKEFLAGS += -r
> -override CFLAGS += -O2 -Wall -g -D_GNU_SOURCE -I$(OUTPUT)include -
> I/usr/include/libnl3
> +override CFLAGS += -O2 -Wall -g -D_GNU_SOURCE -I$(OUTPUT)include -
> I$(shell $(CC) -print-sysroot)/usr/include/libnl3
>  override LDFLAGS += -lnl-genl-3 -lnl-3
>  
>  ALL_TARGETS := intel-speed-select