linux-kernel - Re: [PATCH v2] arm64: defconfig: Enable TISCI Interrupt Router and Aggregator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdUOMCxfsOrUF3-6PX0ZZ_E2g1SK4bwDqZE=mWiibPFt1A@mail.gmail.com>
Date: Tue, 4 Feb 2025 08:42:44 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Vaishnav Achath <vaishnav.a@...com>
Cc: catalin.marinas@....com, will@...nel.org, quic_bjorande@...cinc.com, 
	geert+renesas@...der.be, krzysztof.kozlowski@...aro.org, 
	dmitry.baryshkov@...aro.org, arnd@...db.de, nfraprado@...labora.com, 
	ebiggers@...gle.com, ardb@...nel.org, nm@...com, vigneshr@...com, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	nfrayer@...libre.com, glaroque@...libre.com, tglx@...utronix.de, 
	u-kumar1@...com
Subject: Re: [PATCH v2] arm64: defconfig: Enable TISCI Interrupt Router and Aggregator

Hi Vaishnav,

Thanks for your patch!

On Mon, 3 Feb 2025 at 16:08, Vaishnav Achath <vaishnav.a@...com> wrote:
> Enable TISCI Interrupt Router and Interrupt Aggregator drivers.
> These IPs are found in all TI K3 SoCs like J721E, AM62X and is required
> for core functionality like DMA, GPIO Interrupts which is necessary
> during boot, thus make them built-in.
>
> bloat-o-meter summary on vmlinux:
>         add/remove: 460/1 grow/shrink: 4/0 up/down: 162483/-8 (162475)
>         ...
>         Total: Before=31615984, After=31778459, chg +0.51%

My first thought was: that's a hefty size increase for two rather
small drivers!  So I enabled these two options in one of my own kernel
configs, and saw a size increase of only 7872 bytes...

> Fixes: 2d95ffaecbc2 ("irqchip/ti-sci-intr: Add module build support")
> Fixes: b8b26ae398c4 ("irqchip/ti-sci-inta : Add module build support")
>
> Signed-off-by: Vaishnav Achath <vaishnav.a@...com>
> ---
>
> V1 : https://lore.kernel.org/all/20250119182121.3956546-1-vaishnav.a@ti.com/
>
> V1->V2:
>         * Add Fixes tag.
>         * Add bloat-o-meter summary to commit message.
>
> Previously both of these configs were selected for ARCH_K3 in respective
> Kconfigs, but commit b8b26ae398c4 ("irqchip/ti-sci-inta : Add module build support")
> and commit 2d95ffaecbc2 ("irqchip/ti-sci-intr: Add module build support")
> in dropped this recently without adding those back in arm64
> defconfig, this causes boot failure in all TI K3 platforms.
>
> Passing bootlog with configs enabled:
> https://gist.github.com/vaishnavachath/03d8d3ce0f22219643c2f4d1dd243fd1
>
>  arch/arm64/configs/defconfig | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index cb7da4415599..1f25423de383 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -1551,6 +1551,8 @@ CONFIG_PWM_VISCONTI=m
>  CONFIG_SL28CPLD_INTC=y
>  CONFIG_QCOM_PDC=y
>  CONFIG_QCOM_MPM=y
> +CONFIG_TI_SCI_INTR_IRQCHIP=y
> +CONFIG_TI_SCI_INTA_IRQCHIP=y
>  CONFIG_RESET_GPIO=m
>  CONFIG_RESET_IMX7=y
>  CONFIG_RESET_QCOM_AOSS=y

However, on arm64 defconfig, this has indeed a much bigger impact,
as it also (re)enables several other drivers that depend on the
irqchip symbols.

You probably want to mention that in the commit message...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds