linux-kernel - Re: [PATCH] platform/x86/intel/ifs: Update documentation with image download path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50ba78dc-f60d-63de-80fd-ef9b1fc68c72@linux.intel.com>
Date: Tue, 4 Feb 2025 10:07:29 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Jithu Joseph <jithu.joseph@...el.com>
cc: Hans de Goede <hdegoede@...hat.com>, LKML <linux-kernel@...r.kernel.org>, 
    platform-driver-x86@...r.kernel.org, tony.luck@...el.com, 
    ashok.raj.linux@...il.com, anisse@...ier.eu
Subject: Re: [PATCH] platform/x86/intel/ifs: Update documentation with image
 download path

On Fri, 31 Jan 2025, Jithu Joseph wrote:

> The documentation previously listed the path to download In Field Scan
> (IFS) test images as "TBD".
> 
> Update the documentation to include the correct image download location.
> Also move the download link to the appropriate section within the doc.
> 
> Signed-off-by: Jithu Joseph <jithu.joseph@...el.com>

I've applied this patch into the fixes branch with Anisse added as
Reported-by.

Thanks Anisse for raising this issue and Jithu for getting the gears 
moving to provide an useful resolution.

> ---
>  drivers/platform/x86/intel/ifs/ifs.h | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/platform/x86/intel/ifs/ifs.h b/drivers/platform/x86/intel/ifs/ifs.h
> index 5c3c0dfa1bf8..41fc21e7ef14 100644
> --- a/drivers/platform/x86/intel/ifs/ifs.h
> +++ b/drivers/platform/x86/intel/ifs/ifs.h
> @@ -23,12 +23,14 @@
>   * IFS Image
>   * ---------
>   *
> - * Intel provides a firmware file containing the scan tests via
> - * github [#f1]_.  Similar to microcode there is a separate file for each
> + * Intel provides firmware files containing the scan tests via the webpage [#f1]_.
> + * Look under "In-Field Scan Test Images Download" section towards the
> + * end of the page. Similar to microcode there are separate files for each
>   * family-model-stepping. IFS Images are not applicable for some test types.
>   * Wherever applicable the sysfs directory would provide a "current_batch" file
>   * (see below) for loading the image.
>   *
> + * .. [#f1] https://intel.com/InFieldScan
>   *
>   * IFS Image Loading
>   * -----------------
> @@ -125,9 +127,6 @@
>   * 2) Hardware allows for some number of cores to be tested in parallel.
>   * The driver does not make use of this, it only tests one core at a time.
>   *
> - * .. [#f1] https://github.com/intel/TBD
> - *
> - *
>   * Structural Based Functional Test at Field (SBAF):
>   * -------------------------------------------------
>   *
> 
> base-commit: ffd294d346d185b70e28b1a28abe367bbfe53c04
> 

-- 
 i.