linux-kernel - Re: [PATCH v2] ARM: zynq: Do not define address/size-cells for nand-controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d98b9294-32c2-4333-bda9-9d18cef35675@amd.com>
Date: Tue, 4 Feb 2025 09:34:18 +0100
From: Michal Simek <michal.simek@....com>
To: linux-kernel@...r.kernel.org, monstr@...str.eu, michal.simek@...inx.com,
 git@...inx.com
Cc: Conor Dooley <conor+dt@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Rob Herring <robh@...nel.org>,
 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
 <devicetree@...r.kernel.org>,
 "moderated list:ARM/ZYNQ ARCHITECTURE" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2] ARM: zynq: Do not define address/size-cells for
 nand-controller



On 1/7/25 08:01, Michal Simek wrote:
> There is no reason to define address/size-cells without defining child
> nodes in zynq-7000.dtsi. Define it in board file instead.
> 
> Signed-off-by: Michal Simek <michal.simek@....com>
> ---
> 
> Changes in v2:
> - Update also zynq-ebaz4205.dts
> - Update commit message
> - Send it separately v1
>    https://lore.kernel.org/all/37057526d8ee14416f61fb6e2b82bed65bde5d3c.1733920873.git.michal.simek@amd.com/
> 
>   arch/arm/boot/dts/xilinx/zynq-7000.dtsi    | 2 --
>   arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts | 2 ++
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/xilinx/zynq-7000.dtsi b/arch/arm/boot/dts/xilinx/zynq-7000.dtsi
> index 4a29216a6d64..153b8d93cbee 100644
> --- a/arch/arm/boot/dts/xilinx/zynq-7000.dtsi
> +++ b/arch/arm/boot/dts/xilinx/zynq-7000.dtsi
> @@ -303,8 +303,6 @@ nfc0: nand-controller@0,0 {
>   				compatible = "arm,pl353-nand-r2p1";
>   				reg = <0 0 0x1000000>;
>   				status = "disabled";
> -				#address-cells = <1>;
> -				#size-cells = <0>;
>   			};
>   			nor0: flash@1,0 {
>   				status = "disabled";
> diff --git a/arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts b/arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts
> index 53fa6dbfd8fd..14f644156a6f 100644
> --- a/arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts
> +++ b/arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts
> @@ -51,6 +51,8 @@ &gpio0 {
>   &nfc0 {
>   	status = "okay";
>   
> +	#address-cells = <1>;
> +	#size-cells = <0>;
>   	nand@0 {
>   		reg = <0>;
>   	};

Applied.
M