linux-kernel - Re: [PATCH] dt-bindings: mtd: arasan,nand-controller: Ensure all properties are defined

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <29724b4a-dc1d-416e-b8d5-11e85cdf7a85@amd.com>
Date: Tue, 4 Feb 2025 09:41:47 +0100
From: Michal Simek <michal.simek@....com>
To: "Rob Herring (Arm)" <robh@...nel.org>,
 Miquel Raynal <miquel.raynal@...tlin.com>,
 Richard Weinberger <richard@....at>, Vignesh Raghavendra <vigneshr@...com>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-mtd@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: mtd: arasan,nand-controller: Ensure all
 properties are defined



On 2/3/25 22:30, Rob Herring (Arm) wrote:
> Device specific schemas should not allow undefined properties which is
> what 'unevaluatedProperties: true' allows. Fix this constraint.
> 
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> ---
>   .../devicetree/bindings/mtd/arasan,nand-controller.yaml         | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/arasan,nand-controller.yaml b/Documentation/devicetree/bindings/mtd/arasan,nand-controller.yaml
> index 15b63bbb82a2..b90d3b48c2f2 100644
> --- a/Documentation/devicetree/bindings/mtd/arasan,nand-controller.yaml
> +++ b/Documentation/devicetree/bindings/mtd/arasan,nand-controller.yaml
> @@ -42,7 +42,7 @@ required:
>     - clock-names
>     - interrupts
>   
> -unevaluatedProperties: true
> +unevaluatedProperties: false
>   
>   examples:
>     - |

Good thing to do. And we should extend binding to cover other properties which 
are missing in description.
Pretty much remove arasan,has-mdma from DTs and describe power-domains and 
num-cs in binding.

Acked-by: Michal Simek <michal.simek@....com>

Thanks,
Michal