linux-kernel - Re: [PATCH v3] tee: optee: Fix supplicant wait loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHUa44EnCdjEfevuFa4rdTykiD1fjU9+GbVq=TSOPaFz1sZpDA@mail.gmail.com>
Date: Tue, 4 Feb 2025 10:12:20 +0100
From: Jens Wiklander <jens.wiklander@...aro.org>
To: Arnd Bergmann <arnd@...db.de>
Cc: Sumit Garg <sumit.garg@...aro.org>, op-tee@...ts.trustedfirmware.org, 
	Jerome Forissier <jerome.forissier@...aro.org>, dannenberg@...com, javier@...igon.com, 
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v3] tee: optee: Fix supplicant wait loop

On Tue, Feb 4, 2025 at 8:45 AM Arnd Bergmann <arnd@...db.de> wrote:
>
> On Tue, Feb 4, 2025, at 08:34, Sumit Garg wrote:
> > OP-TEE supplicant is a user-space daemon and it's possible for it
> > be hung or crashed or killed in the middle of processing an OP-TEE
> > RPC call. It becomes more complicated when there is incorrect shutdown
> > ordering of the supplicant process vs the OP-TEE client application which
> > can eventually lead to system hang-up waiting for the closure of the
> > client application.
> >
> > Allow the client process waiting in kernel for supplicant response to
> > be killed rather than indefinitely waiting in an unkillable state. Also,
> > a normal uninterruptible wait should not have resulted in the hung-task
> > watchdog getting triggered, but the endless loop would.
> >
> > This fixes issues observed during system reboot/shutdown when supplicant
> > got hung for some reason or gets crashed/killed which lead to client
> > getting hung in an unkillable state. It in turn lead to system being in
> > hung up state requiring hard power off/on to recover.
> >
> > Fixes: 4fb0a5eb364d ("tee: add OP-TEE driver")
> > Suggested-by: Arnd Bergmann <arnd@...db.de>
> > Cc: <stable@...r.kernel.org>
> > Signed-off-by: Sumit Garg <sumit.garg@...aro.org>
>
> Reviewed-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Jens Wiklander <jens.wiklander@...aro.org>

>
> Jens, I assume you'll pick it up and send me a pull request, but
> I can also pick it up directly if you have nothing else.

I have nothing else, please pick up this directly.

Thanks,
Jens