linux-kernel - Re: [PATCH v1 1/1] kthread: Return the assigned value rather than 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z6FjGV1-CxE12f8L@pavilion.home>
Date: Tue, 4 Feb 2025 01:45:13 +0100
From: Frederic Weisbecker <frederic@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/1] kthread: Return the assigned value rather than 0

Le Mon, Feb 03, 2025 at 06:48:55PM +0200, Andy Shevchenko a écrit :
> Recently introduced kthread_affine_preferred() has a bug that the value
> of ret variable set but not used. This breaks the compilation with error
> (assume default CONFIG_WERROR=y and `make W=1` to run the build):
> 
> kernel/kthread.c:862:6: error: variable 'ret' set but not used [-Werror,-Wunused-but-set-variable]
> 
> Fixes: 4d13f4304fa4 ("kthread: Implement preferred affinity")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Thanks but I already have it queued there:

https://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git/commit/?h=kthread/fixes&id=1b0332a42656b798bea867631d739de023633ec6

I'll do a pull request shortly.

Thanks!