linux-kernel - Re: [PATCHv3 06/11] mm/vmscan: Use PG_dropbehind instead of PG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250203164733.f806902a6e5c91523c9e00fc@linux-foundation.org>
Date: Mon, 3 Feb 2025 16:47:33 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
Cc: Kairui Song <ryncsn@...il.com>, "Matthew Wilcox (Oracle)"
 <willy@...radead.org>, Jens Axboe <axboe@...nel.dk>, "Jason A. Donenfeld"
 <Jason@...c4.com>, Andi Shyti <andi.shyti@...ux.intel.com>, Chengming Zhou
 <chengming.zhou@...ux.dev>, Christian Brauner <brauner@...nel.org>,
 Christophe Leroy <christophe.leroy@...roup.eu>, Dan Carpenter
 <dan.carpenter@...aro.org>, David Airlie <airlied@...il.com>, David
 Hildenbrand <david@...hat.com>, Hao Ge <gehao@...inos.cn>, Jani Nikula
 <jani.nikula@...ux.intel.com>, Johannes Weiner <hannes@...xchg.org>, Joonas
 Lahtinen <joonas.lahtinen@...ux.intel.com>, Josef Bacik
 <josef@...icpanda.com>, Masami Hiramatsu <mhiramat@...nel.org>, Mathieu
 Desnoyers <mathieu.desnoyers@...icios.com>, Miklos Szeredi
 <miklos@...redi.hu>, Nhat Pham <nphamcs@...il.com>, Oscar Salvador
 <osalvador@...e.de>, Ran Xiaokai <ran.xiaokai@....com.cn>, Rodrigo Vivi
 <rodrigo.vivi@...el.com>, Simona Vetter <simona@...ll.ch>, Steven Rostedt
 <rostedt@...dmis.org>, Tvrtko Ursulin <tursulin@...ulin.net>, Vlastimil
 Babka <vbabka@...e.cz>, Yosry Ahmed <yosryahmed@...gle.com>, Yu Zhao
 <yuzhao@...gle.com>, intel-gfx@...ts.freedesktop.org,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
 linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCHv3 06/11] mm/vmscan: Use PG_dropbehind instead of
 PG_reclaim

On Mon, 3 Feb 2025 10:39:58 +0200 "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com> wrote:

> > diff --git a/mm/filemap.c b/mm/filemap.c
> > index 4fe551037bf7..98493443d120 100644
> > --- a/mm/filemap.c
> > +++ b/mm/filemap.c
> > @@ -1605,8 +1605,9 @@ static void folio_end_reclaim_write(struct folio *folio)
> >          * invalidation in that case.
> >          */
> >         if (in_task() && folio_trylock(folio)) {
> > -               if (folio->mapping)
> > -                       folio_unmap_invalidate(folio->mapping, folio, 0);
> > +               struct address_space *mapping = folio_mapping(folio);
> > +               if (mapping)
> > +                       folio_unmap_invalidate(mapping, folio, 0);
> >                 folio_unlock(folio);
> >         }
> >  }
> 
> Once you do this, folio_unmap_invalidate() will never succeed for
> swapcache as folio->mapping != mapping check will always be true and it
> will fail with -EBUSY.
> 
> I guess we need to do something similar to what __remove_mapping() does
> for swapcache folios.

Thanks, I'll drop the v3 series from mm.git.