linux-kernel - Re: [PATCH v9 27/28] media: iris: enable video driver probe of SM8250 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z6HjbXZsR9QmXxKy@hovoldconsulting.com>
Date: Tue, 4 Feb 2025 10:52:45 +0100
From: Johan Hovold <johan@...nel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: Dikshita Agarwal <quic_dikshita@...cinc.com>,
	Vikash Garodia <quic_vgarodia@...cinc.com>,
	Abhinav Kumar <quic_abhinavk@...cinc.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Hans Verkuil <hverkuil@...all.nl>,
	Sebastian Fricke <sebastian.fricke@...labora.com>,
	Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
	Neil Armstrong <neil.armstrong@...aro.org>,
	Nicolas Dufresne <nicolas@...fresne.ca>,
	Uwe Kleine-König <u.kleine-koenig@...libre.com>,
	Jianhua Lu <lujianhua000@...il.com>,
	Stefan Schmidt <stefan.schmidt@...aro.org>,
	linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Bjorn Andersson <andersson@...nel.org>
Subject: Re: [PATCH v9 27/28] media: iris: enable video driver probe of
 SM8250 SoC

On Mon, Feb 03, 2025 at 05:37:28PM +0200, Dmitry Baryshkov wrote:
> On Mon, Feb 03, 2025 at 09:39:00AM +0100, Johan Hovold wrote:
> > On Fri, Jan 10, 2025 at 08:01:21PM +0200, Dmitry Baryshkov wrote:

> > > Also as venus and iris drivers are not completely
> > > equivalent wrt supported platforms, distributions will have to select
> > > whether to disable support for older platforms or for new platforms:
> > > Kconfig dependency will make it impossible to enable support for both
> > > kinds.
> > 
> > You shouldn't have both enabled. The only reason for keeping support
> > for the same hardware in both drivers is that the iris support is
> > incomplete and considered experimental. No one should enable that except
> > for development and evaluation purposes until the driver is up to par.
> > And then you drop support from the old driver along with the config
> > option.
> 
> That's the plan. This modparam is a temporal thing for transition
> period. And yes, as a developers / platform enablers we want to be able
> to have a quick turnaround between drivers.
> 
> Please stop forcing your decisions on other people. The Linux kernel and
> its development process has always been about providing a possibility,
> not a policy.

That's just not true. The rule is to not have two drivers for the same
hardware (even if we very rarely have accepted some well-motivated
exceptions).

I understand that you may have an unorthodox view of this as you work on
the MSM DRM driver, but hiding incomplete and broken code behind module
parameters so that you can game the upstreaming process (e.g. like you
did for the eDP PSR feature) is simply not a model that anyone should
follow.

Johan