linux-kernel - Re: [PATCH 1/7] firmware: cs_dsp: Fix error checking in wseq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z6HmAvLwpwmmXd3U@opensource.cirrus.com>
Date: Tue, 4 Feb 2025 10:03:46 +0000
From: Charles Keepax <ckeepax@...nsource.cirrus.com>
To: Fred Treven <ftreven@...nsource.cirrus.com>
CC: Simon Trimmer <simont@...nsource.cirrus.com>,
        Richard Fitzgerald
	<rf@...nsource.cirrus.com>,
        <patches@...nsource.cirrus.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/7] firmware: cs_dsp: Fix error checking in wseq_write()

On Fri, Jan 31, 2025 at 01:56:32PM -0600, Fred Treven wrote:
> cs_dsp_coeff_write_ctrl() may return a non-zero value (1)
> upon success. Change error checking in the write sequencer
> code such that it checks for negative errnos rather than
> any non-zero value when using this function.
> 
> Signed-off-by: Fred Treven <ftreven@...nsource.cirrus.com>
> ---

Reviewed-by: Charles Keepax <ckeepax@...nsource.cirrus.com>

Thanks,
Charles