linux-kernel - Re: [PATCH v1 1/6] serial: port: Assign ->iotype correctly when ->iobase is set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025020459-shelf-wanted-1349@gregkh>
Date: Tue, 4 Feb 2025 14:45:17 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Guanbing Huang <albanhuang@...cent.com>, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org, Jiri Slaby <jirislaby@...nel.org>
Subject: Re: [PATCH v1 1/6] serial: port: Assign ->iotype correctly when
 ->iobase is set

On Fri, Jan 24, 2025 at 06:10:46PM +0200, Andy Shevchenko wrote:
> Currently the ->iotype is always assigned to the UPIO_MEM when
> the respective property is not found. However, this will not
> support the cases when user wants to have UPIO_PORT to be set
> or preserved.  Support this scenario by checking ->iobase value
> and default the ->iotype respectively.
> 
> Fixes: 1117a6fdc7c1 ("serial: 8250_of: Switch to use uart_read_port_properties()")
> Fixes: e894b6005dce ("serial: port: Introduce a common helper to read properties")

You forgot the cc: stable lines.  I'll go add them in, but be more
careful next time please.

thanks,

greg k-h