linux-kernel - Re: [Intel-wired-lan] [PATCH] net: e1000e: convert to ndo_hwtstamp_get() and ndo_hwtstamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <16199c68-3a65-456f-8d52-9a98be3d73f6@linux.dev>
Date: Tue, 4 Feb 2025 14:00:03 +0000
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Paul Menzel <pmenzel@...gen.mpg.de>,
 Piotr Wejman <piotrwejman90@...il.com>
Cc: Tony Nguyen <anthony.l.nguyen@...el.com>,
 Przemek Kitszel <przemyslaw.kitszel@...el.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH] net: e1000e: convert to
 ndo_hwtstamp_get() and ndo_hwtstamp_set()

On 03/02/2025 16:41, Paul Menzel wrote:
> Dear Piotr,
> 
> 
> Thank you for your patch.
> 
> Am 02.02.25 um 18:08 schrieb Piotr Wejman:
>> Update the driver to the new hw timestamping API.
> 
> Could you please elaborate. Maybe a pointer to the new API, and what 
> commit added it, and what tests were done, and/or are needed?

The new API was added in 66f7223039c0 ("net: add NDOs for configuring
hardware timestamping") back in 2023, the old ioctl interface is in
deprecated state now.

> 
>> Signed-off-by: Piotr Wejman <piotrwejman90@...il.com>
>> ---
>>   drivers/net/ethernet/intel/e1000e/e1000.h  |  2 +-
>>   drivers/net/ethernet/intel/e1000e/netdev.c | 52 ++++++++--------------
>>   2 files changed, 20 insertions(+), 34 deletions(-)
> 
> 
> Kind regards,
> 
> Paul