linux-kernel - Re: [PATCH net-next v3 09/10] net: pktgen: fix mpls reset parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250204144542.GL234677@kernel.org>
Date: Tue, 4 Feb 2025 14:45:42 +0000
From: Simon Horman <horms@...nel.org>
To: Peter Seiderer <ps.report@....net>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-kselftest@...r.kernel.org,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Shuah Khan <shuah@...nel.org>, Nam Cao <namcao@...utronix.de>,
	Thomas Gleixner <tglx@...utronix.de>,
	Frederic Weisbecker <frederic@...nel.org>,
	Artem Chernyshev <artem.chernyshev@...-soft.ru>
Subject: Re: [PATCH net-next v3 09/10] net: pktgen: fix mpls reset parsing

On Mon, Feb 03, 2025 at 06:02:00PM +0100, Peter Seiderer wrote:
> Fix mpls list reset parsing to work as describe in
> Documentation/networking/pktgen.rst:
> 
>   pgset "mpls 0"    turn off mpls (or any invalid argument works too!)
> 
> - before the patch
> 
> 	$ echo "mpls 00000001,00000002" > /proc/net/pktgen/lo\@0
> 	$ grep mpls /proc/net/pktgen/lo\@0
> 	     mpls: 00000001, 00000002
> 	Result: OK: mpls=00000001,00000002
> 
> 	$ echo "mpls 00000001,00000002" > /proc/net/pktgen/lo\@0
> 	$ echo "mpls 0" > /proc/net/pktgen/lo\@0
> 	$ grep mpls /proc/net/pktgen/lo\@0
> 	     mpls: 00000000
> 	Result: OK: mpls=00000000
> 
> 	$ echo "mpls 00000001,00000002" > /proc/net/pktgen/lo\@0
> 	$ echo "mpls invalid" > /proc/net/pktgen/lo\@0
> 	$ grep mpls /proc/net/pktgen/lo\@0
> 	Result: OK: mpls=
> 
> - after the patch
> 
> 	$ echo "mpls 00000001,00000002" > /proc/net/pktgen/lo\@0
> 	$ grep mpls /proc/net/pktgen/lo\@0
> 	     mpls: 00000001, 00000002
> 	Result: OK: mpls=00000001,00000002
> 
> 	$ echo "mpls 00000001,00000002" > /proc/net/pktgen/lo\@0
> 	$ echo "mpls 0" > /proc/net/pktgen/lo\@0
> 	$ grep mpls /proc/net/pktgen/lo\@0
> 	Result: OK: mpls=
> 
> 	$ echo "mpls 00000001,00000002" > /proc/net/pktgen/lo\@0
> 	$ echo "mpls invalid" > /proc/net/pktgen/lo\@0
> 	$ grep mpls /proc/net/pktgen/lo\@0
> 	Result: OK: mpls=
> 
> Signed-off-by: Peter Seiderer <ps.report@....net>

Reviewed-by: Simon Horman <horms@...nel.org>