linux-kernel - Re: [PATCH v13 2/8] mm: rust: add vm_area_struct methods that require read access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <gugvzktfdeuafnn3mqd64mds2vydes7ta5ma3bunnhwbqazzp5@szoe7ys5zl2h>
Date: Tue, 4 Feb 2025 09:58:35 -0500
From: "Liam R. Howlett" <Liam.Howlett@...cle.com>
To: Alice Ryhl <aliceryhl@...gle.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, Matthew Wilcox <willy@...radead.org>,
        Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
        Vlastimil Babka <vbabka@...e.cz>, John Hubbard <jhubbard@...dia.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arnd Bergmann <arnd@...db.de>, Jann Horn <jannh@...gle.com>,
        Suren Baghdasaryan <surenb@...gle.com>,
        Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>,
        Gary Guo <gary@...yguo.net>,
        Björn Roy Baron <bjorn3_gh@...tonmail.com>,
        Benno Lossin <benno.lossin@...ton.me>,
        Andreas Hindborg <a.hindborg@...nel.org>,
        Trevor Gross <tmgross@...ch.edu>, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, rust-for-linux@...r.kernel.org
Subject: Re: [PATCH v13 2/8] mm: rust: add vm_area_struct methods that
 require read access

* Alice Ryhl <aliceryhl@...gle.com> [250204 07:46]:
> On Mon, Feb 3, 2025 at 4:44 PM Liam R. Howlett <Liam.Howlett@...cle.com> wrote:
> >
> > * Alice Ryhl <aliceryhl@...gle.com> [250203 07:15]:
> >
> > Hi Alice,
> >
> > These comments are probably for my education.  I'm holding back my
> > training on naming and trying to reconcile the snake-case and upper case
> > camel of the rust language.
> >
> > > This adds a type called VmAreaRef which is used when referencing a vma
> >
> > How did you land on VmAreaRef?  Why not VmaRef?  We mostly use vma for
> > vmas today, not vm_area.  Is it because the header declares it
> > vm_area_struct?  I'd be happier with VmaRef, but I'm guessing this is a
> > direct translation from vm_area_struct?
> 
> Sorry missed this on my first pass.
> 
> Yes, it follows the C name. Happy to rename to VmaRef.

I don't want to cause churn on a v13 patch set and I've lived with the
verbose vm_area_struct..

It does cause function declarations to split lines frequently.

It's up to you, I'll accept it whatever way you decide.

Thanks,
Liam