linux-kernel - Re: [PATCH net v3] net: fec: Refactor MAC reset to function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250204074504.523c794c@kernel.org>
Date: Tue, 4 Feb 2025 07:45:04 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: "Csókás, Bence" <csokas.bence@...lan.hu>
Cc: Laurent Badel <laurentbadel@...on.com>, Andrew Lunn <andrew@...n.ch>,
 <imx@...ts.linux.dev>, <netdev@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, Ahmad Fatoum <a.fatoum@...gutronix.de>,
 Simon Horman <horms@...nel.org>, Michal Swiatkowski
 <michal.swiatkowski@...ux.intel.com>, Jacob Keller
 <jacob.e.keller@...el.com>, Wei Fang <wei.fang@....com>, Shenwei Wang
 <shenwei.wang@....com>, Clark Wang <xiaoning.wang@....com>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, "Eric
 Dumazet" <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net v3] net: fec: Refactor MAC reset to function

On Tue, 4 Feb 2025 10:37:54 +0100 Csókás, Bence wrote:
> For instance, as of now, `fec_stop()` does not check for
> `FEC_QUIRK_NO_HARD_RESET`, meaning the MII/RMII mode is cleared on eg.
> a PM power-down event; and `fec_restart()` missed the refactor renaming
> the "magic" constant `1` to `FEC_ECR_RESET`.

Laurent responded to v1 saying this was intentional. Please give more
details on how problem you're seeing and on what platforms. Otherwise
this is not a fix but refactoring.

Please don't post new versions in-reply-to, and add lore links to
the previous version in the changelog.
-- 
pw-bot: cr