linux-kernel - RE: [PATCH v2] arm64: dts: socfpga: agilex5: add NAND board file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BL3PR11MB6532426A08A1C84AA971E6C3A2F72@BL3PR11MB6532.namprd11.prod.outlook.com>
Date: Wed, 5 Feb 2025 13:43:25 +0000
From: "Rabara, Niravkumar L" <niravkumar.l.rabara@...el.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Dinh Nguyen <dinguyen@...nel.org>,
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, "nirav.rabara@...era.com"
	<nirav.rabara@...era.com>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] arm64: dts: socfpga: agilex5: add NAND board file

Hi Krysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: Wednesday, 5 February, 2025 7:31 PM
> To: Rabara, Niravkumar L <niravkumar.l.rabara@...el.com>; Dinh Nguyen
> <dinguyen@...nel.org>; Rob Herring <robh@...nel.org>; Krzysztof Kozlowski
> <krzk+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>;
> nirav.rabara@...era.com; devicetree@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: Re: [PATCH v2] arm64: dts: socfpga: agilex5: add NAND board file
> 
> On 05/02/2025 11:13, niravkumar.l.rabara@...el.com wrote:
> > diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_nand.dts
> > b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_nand.dts
> > new file mode 100644
> > index 000000000000..ccc9be2cd7c6
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_nand.dts
> > @@ -0,0 +1,89 @@
> > +// SPDX-License-Identifier:     GPL-2.0
> > +/*
> > + * Copyright (C) 2025, Altera Corporation  */ #include
> > +"socfpga_agilex5.dtsi"
> > +
> > +/ {
> > +	model = "SoCFPGA Agilex5 SoCDK";
> > +	compatible = "intel,socfpga-agilex5-socdk", "intel,socfpga-agilex5";
> 
> 
> You cannot use other boards compatibles. Different device, different
> compatible.
> 

Same Agilex5 development kit board supports a separate NAND
daughter card.
Default daughter card with SDMMC on Agilex5 devkit required to
replaced with this NAND daughter card to use NAND flash with
Agilex5 devkit. 

Maybe I should replace the "NAND board" to "NAND daughter board" 
for the patch title. 

Is this reasonable?

Thanks,
Nirav