linux-kernel - Re: [PATCH net-next v4 27/27] dt-bindings: net: pse-pd: ti,tps23881: Add interrupt description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250205151822.06f60e8d@kmaincent-XPS-13-7390>
Date: Wed, 5 Feb 2025 15:18:22 +0100
From: Kory Maincent <kory.maincent@...tlin.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Andrew Lunn <andrew@...n.ch>, Oleksij Rempel <o.rempel@...gutronix.de>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
 <pabeni@...hat.com>, Jonathan Corbet <corbet@....net>, Donald Hunter
 <donald.hunter@...il.com>, Rob Herring <robh@...nel.org>, Andrew Lunn
 <andrew+netdev@...n.ch>, Simon Horman <horms@...nel.org>, Heiner Kallweit
 <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, Liam Girdwood
 <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, Krzysztof Kozlowski
 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Thomas Petazzoni
 <thomas.petazzoni@...tlin.com>, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, linux-doc@...r.kernel.org, Kyle Swenson
 <kyle.swenson@....tech>, Dent Project <dentproject@...uxfoundation.org>,
 kernel@...gutronix.de, Maxime Chevallier <maxime.chevallier@...tlin.com>,
 devicetree@...r.kernel.org
Subject: Re: [PATCH net-next v4 27/27] dt-bindings: net: pse-pd:
 ti,tps23881: Add interrupt description

Hello Krzysztof,

On Sat, 4 Jan 2025 10:44:49 +0100
Krzysztof Kozlowski <krzk@...nel.org> wrote:

> On Fri, Jan 03, 2025 at 10:13:16PM +0100, Kory Maincent wrote:
> > From: Kory Maincent (Dent Project) <kory.maincent@...tlin.com>
> > 
> > Add an interrupt property to the device tree bindings for the TI TPS23881
> > PSE controller. The interrupt is primarily used to detect classification
> > and disconnection events, which are essential for managing the PSE
> > controller in compliance with the PoE standard.
> >  
> > @@ -62,6 +65,7 @@ unevaluatedProperties: false
> >  required:
> >    - compatible
> >    - reg
> > +  - interrupts  
> 
> Why? That's an ABI change. Commit msg mentions something like "essential
> for standard" so are you saying nothing here was working according to
> standard before?

Yes indeed, the disconnection management did not follow the standard. Without
this series, the power on the ports of this controller is not shut down after a
Powered Device disconnection. Unfortunately, I did not noticed this before.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com