linux-kernel - Re: [PATCH v3 1/2] drm/bridge: it6505: add support DRM_BRIDGE_OP_HDMI to drm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <t2nd3xjgb4nomasdlb5cmgxxystyo66si7gdqafzi56noknzvc@6i366tvzpfl7>
Date: Wed, 5 Feb 2025 16:38:29 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Hermes.wu@....com.tw
Cc: Andrzej Hajda <andrzej.hajda@...el.com>, 
	Neil Armstrong <neil.armstrong@...aro.org>, Robert Foss <rfoss@...nel.org>, 
	Laurent Pinchart <Laurent.pinchart@...asonboard.com>, Jonas Karlman <jonas@...boo.se>, 
	Jernej Skrabec <jernej.skrabec@...il.com>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
	Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, 
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, treapking@...omium.org, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, Pet.Weng@....com.tw, 
	Kenneth.Hung@....com.tw
Subject: Re: [PATCH v3 1/2] drm/bridge: it6505: add support
 DRM_BRIDGE_OP_HDMI to drm_bridge

On Wed, Feb 05, 2025 at 02:41:03PM +0800, Hermes Wu via B4 Relay wrote:
> From: Hermes Wu <Hermes.wu@....com.tw>
> 
> Add DRM_BRIDGE_OP_HDMI to bridge.ops and implement necessary callback
> functions.

Wait.... Now I feel really sorry. I stumbled upon HDMI_related bits and
then I thought that it's a HDMI bridge without actually checking the
datasheet. When you have a hammer, everything looks like a nail...
Except that IT6505 is neither a nail nor an HDMI bridge.

I'm really sorry for pushing you into the wrong way of OP_HDMI. However
I still think that DisplayPort bridges should not implement codec
callbacks directly. Let me play with that over the next few days. I
think in the end we should be able to use .hdmi_audio_*() callbacks
and drm_hdmi_audio_helper.c while not (over)using the OP_HDMI. I'll ping
you in the next few days.

> The native AVI and AUDIO infoframe configuration API are removed.
> 
> In .atomic_enable use
> drm_atomic_helper_connector_hdmi_update_infoframes().
> for infoframe updates.
> 
> Signed-off-by: Hermes Wu <Hermes.wu@....com.tw>
> ---
>  drivers/gpu/drm/bridge/ite-it6505.c | 185 ++++++++++++++++++++++--------------
>  1 file changed, 115 insertions(+), 70 deletions(-)
> 
-- 
With best wishes
Dmitry