linux-kernel - Re: [PATCH] crypto: testmgr - drop unused static const arrays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250205153400.GA1474@sol.localdomain>
Date: Wed, 5 Feb 2025 07:34:00 -0800
From: Eric Biggers <ebiggers@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Herbert Xu <herbert@...dor.apana.org.au>,
	"David S. Miller" <davem@...emloft.net>,
	Arnd Bergmann <arnd@...db.de>,
	Maxime Coquelin <mcoquelin.stm32@...il.com>,
	Lukas Wunner <lukas@...ner.de>, Ard Biesheuvel <ardb@...nel.org>,
	Stefan Berger <stefanb@...ux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Keith Busch <kbusch@...nel.org>, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: testmgr - drop unused static const arrays

On Wed, Feb 05, 2025 at 01:13:15PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The ones[] and zeroes[] definitions were previously used by the
> rocksoft tests that are now gone. With extra warnings enabled,
> gcc now complains about these:
> 
> crypto/testmgr.h:6021:17: error: 'ones' defined but not used [-Werror=unused-const-variable=]
>  6021 | static const u8 ones[4096] = { [0 ... 4095] = 0xff };
>       |                 ^~~~
> crypto/testmgr.h:6020:17: error: 'zeroes' defined but not used [-Werror=unused-const-variable=]
>  6020 | static const u8 zeroes[4096] = { [0 ... 4095] = 0 };
>       |                 ^~~~~~
> 
> Drop them as well.
> 
> Fixes: dad9cb81bc30 ("crypto: crc64-rocksoft - remove from crypto API")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  crypto/testmgr.h | 3 ---
>  1 file changed, 3 deletions(-)
> 

Thanks!  You must have tested today's linux-next.  The fixed commit is from one
of the patches of the series
https://lore.kernel.org/r/20250204195456.GA1385@sol.localdomain which I applied
to the crc tree yesterday.  I've folded in this fix, so it should be fixed in
tomorrow's linux-next.

Would be nice if these warnings were just on by default.

- Eric