linux-kernel - Re: [PATCH] lib/crc32: remove obsolete CRC32 options from defconfig files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAMj1kXFhLhXFPAeT-81E3Vrcw+0CCcWB0vzCGKZdYNWp5kLbkA@mail.gmail.com>
Date: Wed, 5 Feb 2025 16:35:47 +0100
From: Ard Biesheuvel <ardb@...nel.org>
To: Eric Biggers <ebiggers@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org
Subject: Re: [PATCH] lib/crc32: remove obsolete CRC32 options from defconfig files

On Wed, 5 Feb 2025 at 01:05, Eric Biggers <ebiggers@...nel.org> wrote:
>
> From: Eric Biggers <ebiggers@...gle.com>
>
> Remove all remaining references to CONFIG_CRC32_BIT,
> CONFIG_CRC32_SARWATE, CONFIG_CRC32_SLICEBY4, and CONFIG_CRC32_SLICEBY8.
> These options no longer exist, now that we've standardized on a single
> generic CRC32 implementation.
>
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>
> ---
>  arch/arm/configs/moxart_defconfig         | 1 -
>  arch/mips/configs/bcm47xx_defconfig       | 1 -
>  arch/mips/configs/db1xxx_defconfig        | 1 -
>  arch/mips/configs/rt305x_defconfig        | 1 -
>  arch/mips/configs/xway_defconfig          | 1 -
>  arch/powerpc/configs/adder875_defconfig   | 1 -
>  arch/powerpc/configs/ep88xc_defconfig     | 1 -
>  arch/powerpc/configs/mpc866_ads_defconfig | 1 -
>  arch/powerpc/configs/mpc885_ads_defconfig | 1 -
>  arch/powerpc/configs/tqm8xx_defconfig     | 1 -
>  10 files changed, 10 deletions(-)
>

Acked-by: Ard Biesheuvel <ardb@...nel.org>


> diff --git a/arch/arm/configs/moxart_defconfig b/arch/arm/configs/moxart_defconfig
> index 34d079e03b3c5..fa06d98e43fcd 100644
> --- a/arch/arm/configs/moxart_defconfig
> +++ b/arch/arm/configs/moxart_defconfig
> @@ -116,11 +116,10 @@ CONFIG_MOXART_DMA=y
>  CONFIG_EXT3_FS=y
>  CONFIG_TMPFS=y
>  CONFIG_CONFIGFS_FS=y
>  CONFIG_JFFS2_FS=y
>  CONFIG_KEYS=y
> -CONFIG_CRC32_BIT=y
>  CONFIG_DMA_API_DEBUG=y
>  CONFIG_PRINTK_TIME=y
>  CONFIG_DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT=y
>  # CONFIG_ENABLE_MUST_CHECK is not set
>  CONFIG_KGDB=y
> diff --git a/arch/mips/configs/bcm47xx_defconfig b/arch/mips/configs/bcm47xx_defconfig
> index 6a68a96d13f80..f56e8db5da951 100644
> --- a/arch/mips/configs/bcm47xx_defconfig
> +++ b/arch/mips/configs/bcm47xx_defconfig
> @@ -67,11 +67,10 @@ CONFIG_BCMA_DRIVER_GMAC_CMN=y
>  CONFIG_USB=y
>  CONFIG_USB_HCD_BCMA=y
>  CONFIG_USB_HCD_SSB=y
>  CONFIG_LEDS_TRIGGER_TIMER=y
>  CONFIG_LEDS_TRIGGER_DEFAULT_ON=y
> -CONFIG_CRC32_SARWATE=y
>  CONFIG_PRINTK_TIME=y
>  CONFIG_DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT=y
>  CONFIG_DEBUG_INFO_REDUCED=y
>  CONFIG_STRIP_ASM_SYMS=y
>  CONFIG_DEBUG_FS=y
> diff --git a/arch/mips/configs/db1xxx_defconfig b/arch/mips/configs/db1xxx_defconfig
> index 6eff21ff15d54..281dd7d0f8059 100644
> --- a/arch/mips/configs/db1xxx_defconfig
> +++ b/arch/mips/configs/db1xxx_defconfig
> @@ -214,9 +214,8 @@ CONFIG_NLS_UTF8=y
>  CONFIG_SECURITYFS=y
>  CONFIG_CRYPTO_USER=y
>  CONFIG_CRYPTO_CRYPTD=y
>  CONFIG_CRYPTO_USER_API_HASH=y
>  CONFIG_CRYPTO_USER_API_SKCIPHER=y
> -CONFIG_CRC32_SLICEBY4=y
>  CONFIG_FONTS=y
>  CONFIG_FONT_8x8=y
>  CONFIG_MAGIC_SYSRQ=y
> diff --git a/arch/mips/configs/rt305x_defconfig b/arch/mips/configs/rt305x_defconfig
> index 332f9094e8479..8404e0a9d8b22 100644
> --- a/arch/mips/configs/rt305x_defconfig
> +++ b/arch/mips/configs/rt305x_defconfig
> @@ -127,11 +127,10 @@ CONFIG_JFFS2_COMPRESSION_OPTIONS=y
>  CONFIG_SQUASHFS=y
>  # CONFIG_SQUASHFS_ZLIB is not set
>  CONFIG_SQUASHFS_XZ=y
>  CONFIG_CRYPTO_ARC4=m
>  CONFIG_CRC_ITU_T=m
> -CONFIG_CRC32_SARWATE=y
>  # CONFIG_XZ_DEC_X86 is not set
>  # CONFIG_XZ_DEC_POWERPC is not set
>  # CONFIG_XZ_DEC_IA64 is not set
>  # CONFIG_XZ_DEC_ARM is not set
>  # CONFIG_XZ_DEC_ARMTHUMB is not set
> diff --git a/arch/mips/configs/xway_defconfig b/arch/mips/configs/xway_defconfig
> index 08c0aa03fd564..7b91edfe3e075 100644
> --- a/arch/mips/configs/xway_defconfig
> +++ b/arch/mips/configs/xway_defconfig
> @@ -139,11 +139,10 @@ CONFIG_JFFS2_COMPRESSION_OPTIONS=y
>  CONFIG_SQUASHFS=y
>  # CONFIG_SQUASHFS_ZLIB is not set
>  CONFIG_SQUASHFS_XZ=y
>  CONFIG_CRYPTO_ARC4=m
>  CONFIG_CRC_ITU_T=m
> -CONFIG_CRC32_SARWATE=y
>  CONFIG_PRINTK_TIME=y
>  CONFIG_STRIP_ASM_SYMS=y
>  CONFIG_DEBUG_FS=y
>  CONFIG_MAGIC_SYSRQ=y
>  # CONFIG_SCHED_DEBUG is not set
> diff --git a/arch/powerpc/configs/adder875_defconfig b/arch/powerpc/configs/adder875_defconfig
> index 97f4d48517356..3c6445c98a85f 100644
> --- a/arch/powerpc/configs/adder875_defconfig
> +++ b/arch/powerpc/configs/adder875_defconfig
> @@ -42,10 +42,9 @@ CONFIG_THERMAL=y
>  # CONFIG_DNOTIFY is not set
>  CONFIG_TMPFS=y
>  CONFIG_CRAMFS=y
>  CONFIG_NFS_FS=y
>  CONFIG_ROOT_NFS=y
> -CONFIG_CRC32_SLICEBY4=y
>  CONFIG_DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT=y
>  CONFIG_DEBUG_FS=y
>  CONFIG_MAGIC_SYSRQ=y
>  CONFIG_DETECT_HUNG_TASK=y
> diff --git a/arch/powerpc/configs/ep88xc_defconfig b/arch/powerpc/configs/ep88xc_defconfig
> index 50cc59eb36cf1..354180ab94bcc 100644
> --- a/arch/powerpc/configs/ep88xc_defconfig
> +++ b/arch/powerpc/configs/ep88xc_defconfig
> @@ -45,9 +45,8 @@ CONFIG_SERIAL_CPM_CONSOLE=y
>  # CONFIG_DNOTIFY is not set
>  CONFIG_TMPFS=y
>  CONFIG_CRAMFS=y
>  CONFIG_NFS_FS=y
>  CONFIG_ROOT_NFS=y
> -CONFIG_CRC32_SLICEBY4=y
>  CONFIG_DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT=y
>  CONFIG_MAGIC_SYSRQ=y
>  CONFIG_DETECT_HUNG_TASK=y
> diff --git a/arch/powerpc/configs/mpc866_ads_defconfig b/arch/powerpc/configs/mpc866_ads_defconfig
> index 6f449411abf7b..a0d27c59ea788 100644
> --- a/arch/powerpc/configs/mpc866_ads_defconfig
> +++ b/arch/powerpc/configs/mpc866_ads_defconfig
> @@ -37,6 +37,5 @@ CONFIG_EXT4_FS=y
>  CONFIG_TMPFS=y
>  CONFIG_CRAMFS=y
>  CONFIG_NFS_FS=y
>  CONFIG_ROOT_NFS=y
>  CONFIG_CRC_CCITT=y
> -CONFIG_CRC32_SLICEBY4=y
> diff --git a/arch/powerpc/configs/mpc885_ads_defconfig b/arch/powerpc/configs/mpc885_ads_defconfig
> index 77306be62e9ee..89da51d724fb1 100644
> --- a/arch/powerpc/configs/mpc885_ads_defconfig
> +++ b/arch/powerpc/configs/mpc885_ads_defconfig
> @@ -68,11 +68,10 @@ CONFIG_TMPFS=y
>  CONFIG_CRAMFS=y
>  CONFIG_NFS_FS=y
>  CONFIG_ROOT_NFS=y
>  CONFIG_CRYPTO=y
>  CONFIG_CRYPTO_DEV_TALITOS=y
> -CONFIG_CRC32_SLICEBY4=y
>  CONFIG_DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT=y
>  CONFIG_MAGIC_SYSRQ=y
>  CONFIG_DEBUG_FS=y
>  CONFIG_DEBUG_VM_PGTABLE=y
>  CONFIG_DETECT_HUNG_TASK=y
> diff --git a/arch/powerpc/configs/tqm8xx_defconfig b/arch/powerpc/configs/tqm8xx_defconfig
> index 383c0966e92fd..425f10837a185 100644
> --- a/arch/powerpc/configs/tqm8xx_defconfig
> +++ b/arch/powerpc/configs/tqm8xx_defconfig
> @@ -52,9 +52,8 @@ CONFIG_HW_RANDOM=y
>  # CONFIG_DNOTIFY is not set
>  CONFIG_TMPFS=y
>  CONFIG_CRAMFS=y
>  CONFIG_NFS_FS=y
>  CONFIG_ROOT_NFS=y
> -CONFIG_CRC32_SLICEBY4=y
>  CONFIG_DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT=y
>  CONFIG_MAGIC_SYSRQ=y
>  CONFIG_DETECT_HUNG_TASK=y
>
> base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b
> --
> 2.48.1
>