linux-kernel - Re: [PATCH v9 6/7] arm64: dts: qcom: ipq5332: Add PCIe related nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1d78b30c-f71a-4769-b665-7425f00eb5ec@kernel.org>
Date: Wed, 5 Feb 2025 16:54:38 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Varadarajan Narayanan <quic_varada@...cinc.com>
Cc: bhelgaas@...gle.com, lpieralisi@...nel.org, kw@...ux.com,
 manivannan.sadhasivam@...aro.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, vkoul@...nel.org, kishon@...nel.org,
 andersson@...nel.org, konradybcio@...nel.org, p.zabel@...gutronix.de,
 dmitry.baryshkov@...aro.org, quic_nsekar@...cinc.com,
 linux-arm-msm@...r.kernel.org, linux-pci@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-phy@...ts.infradead.org, Praveenkumar I <quic_ipkumar@...cinc.com>,
 Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Subject: Re: [PATCH v9 6/7] arm64: dts: qcom: ipq5332: Add PCIe related nodes

On 05/02/2025 16:53, Krzysztof Kozlowski wrote:
> On 05/02/2025 16:35, Varadarajan Narayanan wrote:
>> On Wed, Feb 05, 2025 at 02:47:13PM +0100, Krzysztof Kozlowski wrote:
>>> On 05/02/2025 11:49, Varadarajan Narayanan wrote:
>>>> On Mon, Feb 03, 2025 at 05:30:32PM +0100, Krzysztof Kozlowski wrote:
>>>>> On 28/01/2025 07:27, Varadarajan Narayanan wrote:
>>>>>>
>>>>>> @@ -479,6 +519,230 @@ frame@...8000 {
>>>>>>  				status = "disabled";
>>>>>>  			};
>>>>>>  		};
>>>>>> +
>>>>>> +		pcie1: pcie@...00000 {
>>>>>> +			compatible = "qcom,pcie-ipq5332", "qcom,pcie-ipq9574";
>>>>>> +			reg = <0x00088000 0x3000>,
>>>>>
>>>>> So as Konrad pointed out now, this was never tested. It's not we who
>>>>> should run tests for you. It's you.
>>>>
>>>> This was tested and it did not flag an error since it is having the order
>>>> specified in the bindings. qcom,pcie.yaml has 4 reg specifications. Two of
>>>
>>>
>>> Hm, then please paste results of dtbs_check W=1 testing. Here.
>>>
>>> I am 100% sure you have there warning and I don't understand your
>>> reluctance to run the tests even after pointing it out by two people.
>>
>> I ran the tests. Not sure which portions to paste. Have attached the full
>> output just in case you are interested in some other detail. Please take a
>> look.
>>
>> Thanks
>> Varada
>>
>> 	$ grep ipq.*dtb dtbs-check.log
> 
> Where is the command you have used?


Although that might not matter - you skipped several warnings with your
grep. So maybe you need to fix your process, not sure.

Best regards,
Krzysztof