linux-kernel - Re: [PATCH 8/9] ASoC: SOF: imx: merge imx8 and imx8ulp drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z6ON8WsNwZtUevKs@lizhi-Precision-Tower-5810>
Date: Wed, 5 Feb 2025 11:12:33 -0500
From: Frank Li <Frank.li@....com>
To: Laurentiu Mihalcea <laurentiumihalcea111@...il.com>
Cc: Bard Liao <yung-chuan.liao@...ux.intel.com>,
	Daniel Baluta <daniel.baluta@....com>,
	Iuliana Prodan <iuliana.prodan@....com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
	Mark Brown <broonie@...nel.org>, linux-kernel@...r.kernel.org,
	linux-sound@...r.kernel.org, imx@...ts.linux.dev
Subject: Re: [PATCH 8/9] ASoC: SOF: imx: merge imx8 and imx8ulp drivers

On Tue, Feb 04, 2025 at 06:46:15PM +0200, Laurentiu Mihalcea wrote:
>
> (snip)
>
> >>  IMX_SOF_DEV_DESC(imx8, sof_imx8_machs, &imx8_chip_info, &sof_imx8_ops, imx_ops_init);
> >>  IMX_SOF_DEV_DESC(imx8x, sof_imx8_machs, &imx8x_chip_info, &sof_imx8_ops, imx_ops_init);
> >>  IMX_SOF_DEV_DESC(imx8m, sof_imx8_machs, &imx8m_chip_info, &sof_imx8_ops, imx_ops_init);
> >> +IMX_SOF_DEV_DESC(imx8ulp, sof_imx8_machs, &imx8ulp_chip_info, &sof_imx8_ops, imx_ops_init);
> >>
> >>  static const struct of_device_id sof_of_imx8_ids[] = {
> >>  	{
> >> @@ -339,6 +448,10 @@ static const struct of_device_id sof_of_imx8_ids[] = {
> >>  		.compatible = "fsl,imx8mp-dsp",
> >>  		.data = &IMX_SOF_DEV_DESC_NAME(imx8m),
> >>  	},
> >> +	{
> >> +		.compatible = "fsl,imx8ulp-dsp",
> >> +		.data = &IMX_SOF_DEV_DESC_NAME(imx8ulp),
> >> +	},
> > Can you put imx8ulp_dai into driver data to avoid of_device_is_compatible()
> > logic?
> >
> > Frank
>
> should be able to add it to "struct imx_chip_info"

Yes, you try it.  Generally if use .data, needn't check compatible in
driver. .data should include all difference formation for difference
compatible string.

Frank


>