linux-kernel - Re: [PATCH] ext4: pass strlen() of the symlink instead of i_size to inode_set_cached

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGudoHFTqtO+TN+LA+ga2t8-O_QwkOSNwnBEGr1mkj0YyPUARg@mail.gmail.com>
Date: Wed, 5 Feb 2025 17:30:56 +0100
From: Mateusz Guzik <mjguzik@...il.com>
To: brauner@...nel.org, tytso@....edu
Cc: kees@...nel.org, viro@...iv.linux.org.uk, jack@...e.cz, 
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org, 
	syzbot+48a99e426f29859818c0@...kaller.appspotmail.com
Subject: Re: [PATCH] ext4: pass strlen() of the symlink instead of i_size to inode_set_cached_link()

On Wed, Feb 5, 2025 at 5:28 PM Mateusz Guzik <mjguzik@...il.com> wrote:
>
> The call to nd_terminate_link() clamps the size to min(i_size,
> sizeof(ei->i_data) - 1), while the subsequent call to
> inode_set_cached_link() fails the possible update.
>

oof.. that should be:
> inode_set_cached_link() fails to take it into account

-- 
Mateusz Guzik <mjguzik gmail.com>