linux-kernel - Re: [PATCH v12 3/3] mtd: Add driver for concatenating devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ffd401b5-9b0d-4339-befd-19b704479ade@web.de>
Date: Wed, 5 Feb 2025 17:23:33 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Amit Kumar Mahapatra <amit.kumar-mahapatra@....com>,
 linux-mtd@...ts.infradead.org, devicetree@...r.kernel.org,
 Conor Dooley <conor+dt@...nel.org>, Krzysztof Kozlowski
 <krzk+dt@...nel.org>, Miquel Raynal <miquel.raynal@...tlin.com>,
 Richard Weinberger <richard@....at>, Rob Herring <robh@...nel.org>,
 Vignesh Raghavendra <vigneshr@...com>
Cc: LKML <linux-kernel@...r.kernel.org>, amitrkcian2002@...il.com,
 Bernhard Frauendienst <kernel@...pam.obeliks.de>, git@....com
Subject: Re: [PATCH v12 3/3] mtd: Add driver for concatenating devices

I suggest to improve implementation details another bit at a few source code places.

Examples:
…
> +++ b/drivers/mtd/mtd_virt_concat.c
> @@ -0,0 +1,254 @@
…
> +static int mtd_virt_concat_create_item(struct device_node *parts,
> +				       unsigned int count)
> +{

+	struct mtd_virt_concat_node *item __free(kfree) = kzalloc(sizeof(*item), GFP_KERNEL);


…
> +int mtd_virt_concat_node_create(void)
> +{
…

+e_nomem:
+	ret = -ENOMEM;
+put_parts:
+	of_node_put(parts);

> +destroy_items:
> +	mtd_virt_concat_destroy_items();
> +
> +	return ret;
> +}
…


Regards,
Markus