linux-kernel - Re: [PATCH v7 2/3] pwm: sophgo: add driver for Sophgo SG2042 PWM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <o4j72fdw6v6aiuvgeufugzptmfpmpws26zp5bf27hdq2i6cng5@yqmdasof3ynp>
Date: Wed, 5 Feb 2025 17:33:38 +0100
From: Uwe Kleine-König <ukleinek@...nel.org>
To: Chen Wang <unicorn_wang@...look.com>
Cc: Chen Wang <unicornxw@...il.com>, robh@...nel.org, krzk+dt@...nel.org, 
	conor+dt@...nel.org, inochiama@...look.com, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-pwm@...r.kernel.org, linux-riscv@...ts.infradead.org, 
	chao.wei@...hgo.com, haijiao.liu@...hgo.com, xiaoguang.xing@...hgo.com, 
	chunzhi.lin@...hgo.com, Sean Young <sean@...s.org>
Subject: Re: [PATCH v7 2/3] pwm: sophgo: add driver for Sophgo SG2042 PWM

Hello,

On Wed, Feb 05, 2025 at 08:57:20PM +0800, Chen Wang wrote:
> On 2025/2/5 18:06, Uwe Kleine-König wrote:
> > I was tempted to apply this patch while reading throug it until nearly
> > the end ...
> > 
> > > +		reset_control_assert(rst);
> > 
> > This is wrong (well, or unneeded). With
> > devm_reset_control_get_optional_shared_deasserted() the devm cleanup
> > cares for reasserting the reset.
> > 
> > > +		return dev_err_probe(dev, ret, "Failed to register PWM chip\n");
> > > +	}
> > > +
> > > +	return 0;
> > > +}
> > 
> > If you want I can apply and squash the following in:
> > 
> > [...]
> > 
> > ack?
> 
> Ack.

Great. Pushed to 

	https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next

with the suggested fixup.

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)