linux-kernel - Re: [PATCH v1 0/9] Use HWMON_CHANNEL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c447e37b-57b5-f4c5-d34b-86b8430d36da@huawei.com>
Date: Wed, 5 Feb 2025 10:08:31 +0800
From: "lihuisong (C)" <lihuisong@...wei.com>
To: Guenter Roeck <linux@...ck-us.net>, Andrew Lunn <andrew@...n.ch>
CC: <linux-hwmon@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-media@...r.kernel.org>, <netdev@...r.kernel.org>,
	<linux-rtc@...r.kernel.org>, <oss-drivers@...igine.com>, <matt@...ostay.sg>,
	<mchehab@...nel.org>, <irusskikh@...vell.com>, <andrew+netdev@...n.ch>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<pabeni@...hat.com>, <louis.peens@...igine.com>, <hkallweit1@...il.com>,
	<linux@...linux.org.uk>, <kabel@...nel.org>, <alexandre.belloni@...tlin.com>,
	<krzk@...nel.org>, <zhanjie9@...ilicon.com>, <zhenglifeng1@...wei.com>,
	<liuyonglong@...wei.com>
Subject: Re: [PATCH v1 0/9] Use HWMON_CHANNEL_INFO macro to simplify code


在 2025/1/24 23:41, Guenter Roeck 写道:
> On 1/24/25 07:08, Andrew Lunn wrote:
>> On Fri, Jan 24, 2025 at 10:26:26AM +0800, Huisong Li wrote:
>>> The HWMON_CHANNEL_INFO macro is provided by hwmon.h and used widely 
>>> by many
>>> other drivers. This series use HWMON_CHANNEL_INFO macro to simplify 
>>> code.
>>>
>>> Huisong Li (9):
>>>    media: video-i2c: Use HWMON_CHANNEL_INFO macro to simplify code
>>>    net: aquantia: Use HWMON_CHANNEL_INFO macro to simplify code
>>>    net: nfp: Use HWMON_CHANNEL_INFO macro to simplify code
>>>    net: phy: marvell: Use HWMON_CHANNEL_INFO macro to simplify code
>>>    net: phy: marvell10g: Use HWMON_CHANNEL_INFO macro to simplify code
>>>    rtc: ab-eoz9: Use HWMON_CHANNEL_INFO macro to simplify code
>>>    rtc: ds3232: Use HWMON_CHANNEL_INFO macro to simplify code
>>>    w1: w1_therm: w1: Use HWMON_CHANNEL_INFO macro to simplify code
>>>    net: phy: aquantia: Use HWMON_CHANNEL_INFO macro to simplify code
>>
>> Please split these patches per subsystem. Maintainers generally have
>> scripts to accept patches, and those scripts don't work when there are
>> patches for other Maintainers mixed in. So you need 4 patchsets,
>> media, net, rtc and w1.
>>
>> I would also like to see the HWMON Maintainers opinion on these. A
>> patchset containing these have already been NACKed once. These patches
>> do however look like valid cleanups. But are they just so you can do
>> something bad in your vendor tree, which will never make it to
>> mainline?
>>
>
> I no longer comment on hwmon related changes outside drivers/hwmon/
> unless there are blatant problems such as someone trying to use an 
> obsolete
> API or abusing the current API.
>
>
All right. Let subsystem maintainer to decide if need to pick it up.
>
> .