linux-kernel - [PATCH] vsprintf: Drop unused assignment of fmt.state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250205172508.55358-1-richard120310@gmail.com>
Date: Thu,  6 Feb 2025 01:25:07 +0800
From: I Hsin Cheng <richard120310@...il.com>
To: pmladek@...e.com
Cc: rostedt@...dmis.org,
	andriy.shevchenko@...ux.intel.com,
	linux@...musvillemoes.dk,
	senozhatsky@...omium.org,
	akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org,
	jserv@...s.ncku.edu.tw,
	shuah@...nel.org,
	I Hsin Cheng <richard120310@...il.com>
Subject: [PATCH] vsprintf: Drop unused assignment of fmt.state

Remove unused assignment of "fmt.state", in both cases the value of
"fmt.state" will be overwritten by either "FORMAT_STATE_PRECISION" or
"FORMAT_STATE_NUM", the value "FORMAT_STATE_NONE" isn't going to be used
after the assignment.

Signed-off-by: I Hsin Cheng <richard120310@...il.com>
---
 lib/vsprintf.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index 56fe96319292..400299465875 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -2569,7 +2569,7 @@ struct fmt format_decode(struct fmt fmt, struct printf_spec *spec)
 			spec->field_width = -spec->field_width;
 			spec->flags |= LEFT;
 		}
-		fmt.state = FORMAT_STATE_NONE;
+
 		goto precision;
 	}
 
@@ -2578,7 +2578,7 @@ struct fmt format_decode(struct fmt fmt, struct printf_spec *spec)
 		if (spec->precision < 0)
 			spec->precision = 0;
 
-		fmt.state = FORMAT_STATE_NONE;
+
 		goto qualifier;
 	}
 
-- 
2.43.0