linux-kernel - Re: [PATCH 10/12] cpufreq/amd-pstate: Add missing NULL ptr check in amd_pstate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c2a31d45-4780-4cbd-a219-53d99449c4ea@amd.com>
Date: Wed, 5 Feb 2025 11:48:44 -0600
From: Mario Limonciello <mario.limonciello@....com>
To: Dhananjay Ugwekar <dhananjay.ugwekar@....com>
Cc: linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
 "Gautham R. Shenoy" <gautham.shenoy@....com>, rafael@...nel.org,
 Viresh Kumar <viresh.kumar@...aro.org>
Subject: Re: [PATCH 10/12] cpufreq/amd-pstate: Add missing NULL ptr check in
 amd_pstate_update

On 2/5/2025 05:25, Dhananjay Ugwekar wrote:
> Check if policy is NULL before dereferencing it in amd_pstate_update.
> 
> Fixes: e8f555daacd3 ("cpufreq/amd-pstate: fix setting policy current frequency value")
> Signed-off-by: Dhananjay Ugwekar <dhananjay.ugwekar@....com>
> ---

Thanks.

Reviewed-by: Mario Limonciello <mario.limonciello@....com>

I'll queue this fix for 6.14-rc.

>   drivers/cpufreq/amd-pstate.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 9c939be59042..6a604f0797d9 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -551,6 +551,9 @@ static void amd_pstate_update(struct amd_cpudata *cpudata, u8 min_perf,
>   	struct cpufreq_policy *policy = cpufreq_cpu_get(cpudata->cpu);
>   	u8 nominal_perf = READ_ONCE(cpudata->nominal_perf);
>   
> +	if (!policy)
> +		return;
> +
>   	des_perf = clamp_t(u8, des_perf, min_perf, max_perf);
>   
>   	policy->cur = perf_to_freq(cpudata, des_perf);