linux-kernel - Re: [PATCH v3 6/8] scsi: ufs: core: Check if scaling up is required when disable clkscale

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <22e97196-5828-4c7f-8e95-4865bf24612c@acm.org>
Date: Wed, 5 Feb 2025 10:05:13 -0800
From: Bart Van Assche <bvanassche@....org>
To: Ziqi Chen <quic_ziqichen@...cinc.com>, quic_cang@...cinc.com,
 mani@...nel.org, beanhuo@...ron.com, avri.altman@....com,
 junwoo80.lee@...sung.com, martin.petersen@...cle.com,
 quic_nguyenb@...cinc.com, quic_nitirawa@...cinc.com,
 quic_rampraka@...cinc.com
Cc: linux-arm-msm@...r.kernel.org, linux-scsi@...r.kernel.org,
 Alim Akhtar <alim.akhtar@...sung.com>,
 "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
 Peter Wang <peter.wang@...iatek.com>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 Andrew Halaney <ahalaney@...hat.com>,
 open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 6/8] scsi: ufs: core: Check if scaling up is required
 when disable clkscale

On 2/3/25 12:11 AM, Ziqi Chen wrote:
> When disabling clkscale via the clkscale_enable sysfs entry, UFS driver
> shall perform scaling up once regardless. Check if scaling up is required
> or not first to avoid repetitive work.
> 
> Co-developed-by: Can Guo <quic_cang@...cinc.com>
> Signed-off-by: Can Guo <quic_cang@...cinc.com>
> Signed-off-by: Ziqi Chen <quic_ziqichen@...cinc.com>
> ---
>   drivers/ufs/core/ufshcd.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index ebab897080a6..bd93119a177d 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -1777,6 +1777,10 @@ static ssize_t ufshcd_clkscale_enable_store(struct device *dev,
>   	freq = clki->max_freq;
>   
>   	ufshcd_suspend_clkscaling(hba);
> +
> +	if (!ufshcd_is_devfreq_scaling_required(hba, freq, true))
> +		goto out_rel;
> +
>   	err = ufshcd_devfreq_scale(hba, freq, true);
>   	if (err)
>   		dev_err(hba->dev, "%s: failed to scale clocks up %d\n",

Reviewed-by: Bart Van Assche <bvanassche@....org>